From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@infradead.org>, Theodore Ts'o <tytso@mit.edu>
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/1] random vs blk-mq
Date: Fri, 25 Apr 2014 08:18:47 -0600 [thread overview]
Message-ID: <535A6EC7.10305@kernel.dk> (raw)
In-Reply-To: <20140425073610.GA2143@infradead.org>
On 04/25/2014 01:36 AM, Christoph Hellwig wrote:
> A tester found out that we need add_disk_randomness for my scsi-mq
> branch. The patch applied exports add_disk_randomness so that modular
> scsi still works with a driver that either uses the low-level I/O
> completion routines for the old block layer, or blk-mq, and I'd love
> to get this in through Jens' tree which has all the other block work
> scsi-mq requires.
>
> But this also brings up an interesting question: blk-mq currently
> does not set QUEUE_FLAG_ADD_RANDOM in the default queue flags, so
> simply converting a driver to blk-mq will mean it stops contributing
> to the random pool. Do we need a more fine grained way to control
> this, especially for SCSI?
Or, we could just fix the horribly slow pool mix and have it always be
on if it's "free", or almost free. Perhaps just default to on for
rotating devices, that'd lessen the impact.
--
Jens Axboe
prev parent reply other threads:[~2014-04-25 14:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 7:36 [PATCH 0/1] random vs blk-mq Christoph Hellwig
2014-04-25 7:36 ` [PATCH 1/1] random: export add_disk_randomness Christoph Hellwig
2014-04-25 13:49 ` Theodore Ts'o
2014-04-28 11:29 ` Christoph Hellwig
2014-04-28 15:17 ` Jens Axboe
2014-04-25 14:03 ` [PATCH 0/1] random vs blk-mq Theodore Ts'o
2014-04-25 14:22 ` Jens Axboe
2014-04-25 14:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535A6EC7.10305@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox