From: Andy Grover <agrover@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: Christoph Hellwig <hch@lst.de>,
target-devel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCHv2 RESEND 0/9] target: Save memory on unused se_dev_entrys and se_luns
Date: Thu, 01 May 2014 14:51:42 -0700 [thread overview]
Message-ID: <5362C1EE.40106@redhat.com> (raw)
In-Reply-To: <1398979268.24007.26.camel@haakon3.risingtidesystems.com>
On 05/01/2014 02:21 PM, Nicholas A. Bellinger wrote:
> So now that target code (plus Sagi's patches) is finally working
> correctly with active I/O shutdown with iser + friends, I'm not exactly
> crazy about introducing a bunch of changes that potentially break long
> standing assumptions about how se_lun + se_dev_entry pointers are
> accessed.
This saves a huge amount of wasted memory per nodeacl and per tpg. It's
a net reduction of 120 lines of code.
If you wanted to push the iser work to Linus by itself, maybe this goes
into your tree immediately after that? That would give it plenty of time
in your tree before it went upstream.
> That said, I'd much rather see proper percpu refcounting for
> se_dev_entry introduced ahead of these types of memory space related
> optimizations.
These patches are not refcount-related, so they should be orthogonal to
any refcount improvements.
I think the set from March 24 should still apply, but I'm happy to
re-send or post a repo if that would be helpful to you.
Regards -- Andy
prev parent reply other threads:[~2014-05-01 21:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-24 23:43 [PATCHv2 RESEND 0/9] target: Save memory on unused se_dev_entrys and se_luns Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 1/9] target: Add locking to some accesses to nacl.device_list Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 2/9] target: Don't unlock/relock tpg_lun_lock in loop in add_node_to_devs Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 3/9] target: Allocate se_dev_entrys in device list only when used Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 4/9] target: core_tpg_post_dellun can return void Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 5/9] target: Change core_dev_del_lun to take a se_lun instead of unpacked_lun Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 6/9] target: Rename core_tpg_post_dellun to remove_lun Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 7/9] target: Allocate se_luns only when used Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 8/9] target: Remove core_tpg_release_virtual_lun0 function Andy Grover
2014-03-24 23:43 ` [PATCHv2 RESEND 9/9] target: Refactor core_enable_device_list_for_node Andy Grover
2014-04-23 22:36 ` [PATCHv2 RESEND 0/9] target: Save memory on unused se_dev_entrys and se_luns Andy Grover
2014-04-25 5:34 ` Christoph Hellwig
2014-05-01 17:53 ` Andy Grover
2014-05-01 21:21 ` Nicholas A. Bellinger
2014-05-01 21:51 ` Andy Grover [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5362C1EE.40106@redhat.com \
--to=agrover@redhat.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).