Re: [PATCH 16/16] scsi_dh_alua: Use workqueue for RTPG

[Hannes Reinecke <hare@suse.de>]

On 04/29/2014 11:47 PM, Stewart, Sean wrote:
> On Fri, 2014-01-31 at 10:30 +0100, Hannes Reinecke wrote:
>> @@ -797,37 +838,40 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)
>>   		off = 8 + (ucp[7] * 4);
>>   	}
>>
>> -	sdev_printk(KERN_INFO, sdev,
>> -		    "%s: port group %02x state %c %s supports %c%c%c%c%c%c%c\n",
>> -		    ALUA_DH_NAME, pg->group_id, print_alua_state(pg->state),
>> -		    pg->pref ? "preferred" : "non-preferred",
>> -		    valid_states&TPGS_SUPPORT_TRANSITION?'T':'t',
>> -		    valid_states&TPGS_SUPPORT_OFFLINE?'O':'o',
>> -		    valid_states&TPGS_SUPPORT_LBA_DEPENDENT?'L':'l',
>> -		    valid_states&TPGS_SUPPORT_UNAVAILABLE?'U':'u',
>> -		    valid_states&TPGS_SUPPORT_STANDBY?'S':'s',
>> -		    valid_states&TPGS_SUPPORT_NONOPTIMIZED?'N':'n',
>> -		    valid_states&TPGS_SUPPORT_OPTIMIZED?'A':'a');
> Hannes,
>
> I was wondering why this was changed from an sdev_printk to a printk? I
> can see the AAS of a TPG on a target, but with it this way I do not know
> with respect to what logical unit it is.
>
>> +	printk(KERN_INFO "%s: target %s port group %02x state %c %s "
>> +	       "supports %c%c%c%c%c%c%c\n", ALUA_DH_NAME, pg->target_id_str,
>> +	       pg->group_id, print_alua_state(pg->state),
>> +	       pg->pref ? "preferred" : "non-preferred",
>> +	       valid_states&TPGS_SUPPORT_TRANSITION?'T':'t',
>> +	       valid_states&TPGS_SUPPORT_OFFLINE?'O':'o',
>> +	       valid_states&TPGS_SUPPORT_LBA_DEPENDENT?'L':'l',
>> +	       valid_states&TPGS_SUPPORT_UNAVAILABLE?'U':'u',
>> +	       valid_states&TPGS_SUPPORT_STANDBY?'S':'s',
>> +	       valid_states&TPGS_SUPPORT_NONOPTIMIZED?'N':'n',
>> +	       valid_states&TPGS_SUPPORT_OPTIMIZED?'A':'a');
>>
>>
>
Reasoning was the the 'target port' is actually independent on the 
scsi device; there might be several scsi devices pointing to the 
same target port. So using 'sdev_printk' here wouldn't be entirely 
correct.

But you are right, we're losing the information about the LUN here.
So I'll be reverting that bit.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html