Re: [PATCH v2] kref: warn on uninitialized kref

Peter Zijlstra
2014-05-19T08:19:46Z

[-- Attachment #1: Type: text/plain, Size: 403 bytes --]

On Sat, May 17, 2014 at 05:14:13PM -0400, Mikulas Patocka wrote:
> BTW. if we talk about performance - what about replacing:
>
> if (atomic_dec_and_test(&variable)) {
> ... release(object);
> }
>
> with this:
>
> if (atomic_read(&variable) == 1 || atomic_dec_and_test(&variable)) {
> barrier();
> ... release(object);
> }

That would completely wreck kref_get_unless_zero().

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]