From: Paolo Bonzini <pbonzini@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
Ulrich Obergfell <uobergfe@redhat.com>
Subject: Re: dangling pointers and/or reentrancy in scmd_eh_abort_handler?
Date: Tue, 20 May 2014 10:40:05 +0200 [thread overview]
Message-ID: <537B14E5.2090100@redhat.com> (raw)
In-Reply-To: <537B0E05.80308@acm.org>
Il 20/05/2014 10:10, Bart Van Assche ha scritto:
> REQ_ATOM_COMPLETE is already set before scsi_eh_scmd_add() is called
> since that function is only invoked after the block layer has marked a
> request as "complete". The only callers of scsi_eh_scmd_add() are
> scsi_softirq_done(), scsi_times_out() and scmd_eh_abort_handler(). That
> last function is invoked (indirectly) by scsi_times_out().
Yes, and answering my own question, you cannot have a dangling pointer
in eh_abort_handler (unless you have a driver bug). This is because
once eh_abort_handler is called, you know the interrupt handler will not
trigger the softirq and scsi_finish_command won't be called.
Paolo
next prev parent reply other threads:[~2014-05-20 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:08 dangling pointers and/or reentrancy in scmd_eh_abort_handler? Paolo Bonzini
2014-05-19 15:08 ` Bart Van Assche
2014-05-19 15:25 ` Christoph Hellwig
2014-05-19 16:09 ` Paolo Bonzini
2014-05-19 16:43 ` Bart Van Assche
2014-05-20 7:32 ` Bart Van Assche
2014-05-20 8:10 ` Bart Van Assche
2014-05-20 8:40 ` Paolo Bonzini [this message]
2014-05-21 14:16 ` Mark Wu
2014-05-21 20:34 ` Paolo Bonzini
2014-05-23 1:28 ` Elliott, Robert (Server Storage)
2014-05-23 9:22 ` Paolo Bonzini
2014-05-20 8:46 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537B14E5.2090100@redhat.com \
--to=pbonzini@redhat.com \
--cc=bvanassche@acm.org \
--cc=linux-scsi@vger.kernel.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).