From: Paolo Bonzini <pbonzini@redhat.com>
To: Mark Wu <wudx05@gmail.com>, linux-scsi@vger.kernel.org
Subject: Re: dangling pointers and/or reentrancy in scmd_eh_abort_handler?
Date: Wed, 21 May 2014 22:34:17 +0200 [thread overview]
Message-ID: <537D0DC9.5010900@redhat.com> (raw)
In-Reply-To: <loom.20140521T161608-391@post.gmane.org>
Il 21/05/2014 16:16, Mark Wu ha scritto:
> Is it possible that when scsi_done is invoked, the scsi command or the
> request has been freed and then reallocated for a new I/O request? Because
> of this the bit flag REQ_ATOM_COMPLETE becomes unreliable. Thanks!
It is up to the driver to ensure that the interrupt handler will not
process the Scsi_Cmnd* after returning from the eh_abort_handler. If
you do this, what you say cannot happen. Otherwise you'll get a variety
of failures, the most common of which for me are OOPSes and a BUG in
blk_finish_request.
Paolo
next prev parent reply other threads:[~2014-05-21 20:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 14:08 dangling pointers and/or reentrancy in scmd_eh_abort_handler? Paolo Bonzini
2014-05-19 15:08 ` Bart Van Assche
2014-05-19 15:25 ` Christoph Hellwig
2014-05-19 16:09 ` Paolo Bonzini
2014-05-19 16:43 ` Bart Van Assche
2014-05-20 7:32 ` Bart Van Assche
2014-05-20 8:10 ` Bart Van Assche
2014-05-20 8:40 ` Paolo Bonzini
2014-05-21 14:16 ` Mark Wu
2014-05-21 20:34 ` Paolo Bonzini [this message]
2014-05-23 1:28 ` Elliott, Robert (Server Storage)
2014-05-23 9:22 ` Paolo Bonzini
2014-05-20 8:46 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537D0DC9.5010900@redhat.com \
--to=pbonzini@redhat.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wudx05@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).