From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
giridhar.malavali@qlogic.com,
Tej Parkash <tej.parkash@qlogic.com>
Subject: Re: [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects
Date: Thu, 22 May 2014 12:29:03 -0500 [thread overview]
Message-ID: <537E33DF.30808@cs.wisc.edu> (raw)
In-Reply-To: <1400499133-32196-1-git-send-email-vikas.chaudhary@qlogic.com>
On 05/19/2014 06:32 AM, vikas.chaudhary@qlogic.com wrote:
> From: Tej Parkash <tej.parkash@qlogic.com>
>
> Signed-off-by: Tej Parkash <tej.parkash@qlogic.com>
> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> ---
> drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> index 166543f..cabc8c1 100644
> --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> @@ -2234,6 +2234,9 @@ static umode_t bnx2i_attr_is_visible(int param_type, int param)
> case ISCSI_PARAM_TGT_RESET_TMO:
> case ISCSI_PARAM_IFACE_NAME:
> case ISCSI_PARAM_INITIATOR_NAME:
> + case ISCSI_PARAM_BOOT_ROOT:
> + case ISCSI_PARAM_BOOT_NIC:
> + case ISCSI_PARAM_BOOT_TARGET:
> return S_IRUGO;
> default:
> return 0;
I think we also wanted this for the chelsio driver, but I need to set it
up to test. So for now, looks ok to me. If chelsio needs it, I can send
a patch for that when done testing.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
next prev parent reply other threads:[~2014-05-22 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 11:32 [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects vikas.chaudhary
2014-05-19 16:54 ` Eddie Wai
2014-05-22 17:29 ` Mike Christie [this message]
2014-09-08 8:02 ` Maurizio Lombardi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537E33DF.30808@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=giridhar.malavali@qlogic.com \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tej.parkash@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).