* [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects
@ 2014-05-19 11:32 vikas.chaudhary
2014-05-19 16:54 ` Eddie Wai
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: vikas.chaudhary @ 2014-05-19 11:32 UTC (permalink / raw)
To: jbottomley, michaelc
Cc: linux-scsi, vikas.chaudhary, giridhar.malavali, Tej Parkash
From: Tej Parkash <tej.parkash@qlogic.com>
Signed-off-by: Tej Parkash <tej.parkash@qlogic.com>
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---
drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
index 166543f..cabc8c1 100644
--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
@@ -2234,6 +2234,9 @@ static umode_t bnx2i_attr_is_visible(int param_type, int param)
case ISCSI_PARAM_TGT_RESET_TMO:
case ISCSI_PARAM_IFACE_NAME:
case ISCSI_PARAM_INITIATOR_NAME:
+ case ISCSI_PARAM_BOOT_ROOT:
+ case ISCSI_PARAM_BOOT_NIC:
+ case ISCSI_PARAM_BOOT_TARGET:
return S_IRUGO;
default:
return 0;
--
1.8.2.GIT
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects
2014-05-19 11:32 [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects vikas.chaudhary
@ 2014-05-19 16:54 ` Eddie Wai
2014-05-22 17:29 ` Mike Christie
2014-09-08 8:02 ` Maurizio Lombardi
2 siblings, 0 replies; 4+ messages in thread
From: Eddie Wai @ 2014-05-19 16:54 UTC (permalink / raw)
To: vikas.chaudhary
Cc: jbottomley, michaelc, linux-scsi, giridhar.malavali, Tej Parkash
FYI, this was part of the boot_nic sysfs patch which would allow iscsid
to sync_session with info from the iBFT for iSCSI BFS via offload.
This looks good to me.
Acked-by: Eddie Wai <eddie.wai@broadcom.com>
On Mon, 2014-05-19 at 07:32 -0400, vikas.chaudhary@qlogic.com wrote:
> From: Tej Parkash <tej.parkash@qlogic.com>
>
> Signed-off-by: Tej Parkash <tej.parkash@qlogic.com>
> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> ---
> drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> index 166543f..cabc8c1 100644
> --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> @@ -2234,6 +2234,9 @@ static umode_t bnx2i_attr_is_visible(int param_type, int param)
> case ISCSI_PARAM_TGT_RESET_TMO:
> case ISCSI_PARAM_IFACE_NAME:
> case ISCSI_PARAM_INITIATOR_NAME:
> + case ISCSI_PARAM_BOOT_ROOT:
> + case ISCSI_PARAM_BOOT_NIC:
> + case ISCSI_PARAM_BOOT_TARGET:
> return S_IRUGO;
> default:
> return 0;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects
2014-05-19 11:32 [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects vikas.chaudhary
2014-05-19 16:54 ` Eddie Wai
@ 2014-05-22 17:29 ` Mike Christie
2014-09-08 8:02 ` Maurizio Lombardi
2 siblings, 0 replies; 4+ messages in thread
From: Mike Christie @ 2014-05-22 17:29 UTC (permalink / raw)
To: vikas.chaudhary; +Cc: jbottomley, linux-scsi, giridhar.malavali, Tej Parkash
On 05/19/2014 06:32 AM, vikas.chaudhary@qlogic.com wrote:
> From: Tej Parkash <tej.parkash@qlogic.com>
>
> Signed-off-by: Tej Parkash <tej.parkash@qlogic.com>
> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> ---
> drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> index 166543f..cabc8c1 100644
> --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> @@ -2234,6 +2234,9 @@ static umode_t bnx2i_attr_is_visible(int param_type, int param)
> case ISCSI_PARAM_TGT_RESET_TMO:
> case ISCSI_PARAM_IFACE_NAME:
> case ISCSI_PARAM_INITIATOR_NAME:
> + case ISCSI_PARAM_BOOT_ROOT:
> + case ISCSI_PARAM_BOOT_NIC:
> + case ISCSI_PARAM_BOOT_TARGET:
> return S_IRUGO;
> default:
> return 0;
I think we also wanted this for the chelsio driver, but I need to set it
up to test. So for now, looks ok to me. If chelsio needs it, I can send
a patch for that when done testing.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects
2014-05-19 11:32 [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects vikas.chaudhary
2014-05-19 16:54 ` Eddie Wai
2014-05-22 17:29 ` Mike Christie
@ 2014-09-08 8:02 ` Maurizio Lombardi
2 siblings, 0 replies; 4+ messages in thread
From: Maurizio Lombardi @ 2014-09-08 8:02 UTC (permalink / raw)
To: jbottomley, Christoph Hellwig
Cc: vikas.chaudhary, michaelc, linux-scsi, giridhar.malavali,
Tej Parkash
Hi Cristoph, Jens,
On 05/19/2014 01:32 PM, vikas.chaudhary@qlogic.com wrote:
> From: Tej Parkash <tej.parkash@qlogic.com>
>
> Signed-off-by: Tej Parkash <tej.parkash@qlogic.com>
> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
> ---
> drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> index 166543f..cabc8c1 100644
> --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> @@ -2234,6 +2234,9 @@ static umode_t bnx2i_attr_is_visible(int param_type, int param)
> case ISCSI_PARAM_TGT_RESET_TMO:
> case ISCSI_PARAM_IFACE_NAME:
> case ISCSI_PARAM_INITIATOR_NAME:
> + case ISCSI_PARAM_BOOT_ROOT:
> + case ISCSI_PARAM_BOOT_NIC:
> + case ISCSI_PARAM_BOOT_TARGET:
> return S_IRUGO;
> default:
> return 0;
>
Can you merge this patch? It has been ACKed already.
Thanks,
Maurizio Lombardi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-08 8:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-19 11:32 [PATCH] bnx2i: Make boot_nic entry visible in the sysfs session objects vikas.chaudhary
2014-05-19 16:54 ` Eddie Wai
2014-05-22 17:29 ` Mike Christie
2014-09-08 8:02 ` Maurizio Lombardi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).