From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type
Date: Fri, 23 May 2014 11:20:01 +0200 [thread overview]
Message-ID: <537F12C1.4080407@redhat.com> (raw)
In-Reply-To: <1400791590.26558.6.camel@haakon3.risingtidesystems.com>
Il 22/05/2014 22:46, Nicholas A. Bellinger ha scritto:
> Hi Fengguang,
>
> On Thu, 2014-05-22 at 11:13 +0800, kbuild test robot wrote:
>> tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next
>> head: 4baaa7d589e24bfe87dfd6c7a1229108be404a28
>> commit: 4baaa7d589e24bfe87dfd6c7a1229108be404a28 [20/20] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD
>> config: x86_64-randconfig-x000 (attached as .config)
>>
>> All error/warnings:
>>
>> drivers/scsi/virtio_scsi.c: In function 'virtio_scsi_init_hdr_pi':
>>>> drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type
>> cmd_pi->pi_bytesout = blk_rq_sectors(rq) * bi->tuple_size;
>> ^
>>>> drivers/scsi/virtio_scsi.c:533:47: error: dereferencing pointer to incomplete type
>> cmd_pi->pi_bytesin = blk_rq_sectors(rq) * bi->tuple_size;
>> ^
>>
>> vim +531 drivers/scsi/virtio_scsi.c
>>
>> 525 if (!rq || !scsi_prot_sg_count(sc))
>> 526 return;
>> 527
>> 528 bi = blk_get_integrity(rq->rq_disk);
>> 529
>> 530 if (sc->sc_data_direction == DMA_TO_DEVICE)
>> > 531 cmd_pi->pi_bytesout = blk_rq_sectors(rq) * bi->tuple_size;
>> 532 else if (sc->sc_data_direction == DMA_FROM_DEVICE)
>> > 533 cmd_pi->pi_bytesin = blk_rq_sectors(rq) * bi->tuple_size;
>> 534 }
>> 535
>> 536 static int virtscsi_queuecommand(struct virtio_scsi *vscsi,
>>
>
> Squashing the following into the original commit to enable blk-integrity
> for virtio-scsi to address the randconfig build failure above.
>
> Thanks!
>
> --nab
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 02832d6..baca589 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1773,6 +1773,7 @@ config SCSI_BFA_FC
> config SCSI_VIRTIO
> tristate "virtio-scsi support"
> depends on VIRTIO
> + select BLK_DEV_INTEGRITY
> help
> This is the virtual HBA driver for virtio. If the kernel will
> be used in a virtual machine, say Y or M.
What about #ifdef'ing VIRTIO_SCSI_F_T10_PI support out if
!CONFIG_BLK_DEV_INTEGRITY?
Paolo
next prev parent reply other threads:[~2014-05-23 9:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <537d6b74.lQGMmmapPq/MP5Nx%fengguang.wu@intel.com>
2014-05-22 20:46 ` [target:for-next 20/20] drivers/scsi/virtio_scsi.c:531:48: error: dereferencing pointer to incomplete type Nicholas A. Bellinger
2014-05-23 9:20 ` Paolo Bonzini [this message]
2014-05-23 17:45 ` Nicholas A. Bellinger
2014-05-26 17:30 ` Martin K. Petersen
2014-05-27 22:21 ` Nicholas A. Bellinger
2014-05-28 11:25 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537F12C1.4080407@redhat.com \
--to=pbonzini@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).