From: Paolo Bonzini <pbonzini@redhat.com>
To: James Bottomley <jbottomley@parallels.com>,
"bvanassche@acm.org" <bvanassche@acm.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"hch@infradead.org" <hch@infradead.org>,
"hare@suse.de" <hare@suse.de>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"jdl1291@gmail.com" <jdl1291@gmail.com>
Subject: Re: [PATCH 2/3] block: Introduce blk_rq_completed()
Date: Tue, 27 May 2014 12:47:26 +0200 [thread overview]
Message-ID: <53846D3E.6050901@redhat.com> (raw)
In-Reply-To: <1401186086.14454.43.camel@dabdike>
Il 27/05/2014 12:21, James Bottomley ha scritto:
> I could also see us one day extending the TMF capability to abort any
> running command, which would make even an assertion of block timed out
> or completed invalid.
Actually the assertion would remain valid, and that's exactly what Bart
wants to document with this assertion.
"Completed" from the point of view of the block layer really means "do
not run the softirq". If you wanted to abort any running command, you
still would mark the request as completed for the block layer before
issuing the TMF.
Paolo
next prev parent reply other threads:[~2014-05-27 10:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 15:12 Make SCSI error handler code easier to understand Bart Van Assche
2014-05-26 15:14 ` [PATCH 1/3] Remove two cancel_delayed_work() calls from the error handler Bart Van Assche
2014-05-26 15:15 ` [PATCH 2/3] block: Introduce blk_rq_completed() Bart Van Assche
2014-05-26 15:27 ` James Bottomley
2014-05-27 7:49 ` Bart Van Assche
2014-05-27 7:52 ` hch
2014-05-27 8:00 ` James Bottomley
2014-05-27 8:23 ` James Bottomley
2014-05-27 9:00 ` Bart Van Assche
2014-05-27 10:21 ` James Bottomley
2014-05-27 10:47 ` Paolo Bonzini [this message]
2014-05-27 10:59 ` James Bottomley
2014-05-27 11:13 ` Paolo Bonzini
2014-05-27 11:26 ` James Bottomley
2014-05-27 11:52 ` Paolo Bonzini
2014-05-27 11:57 ` James Bottomley
2014-05-27 5:40 ` Hannes Reinecke
2014-05-26 15:23 ` [PATCH 1/3] Remove two cancel_delayed_work() calls from the error handler Paolo Bonzini
2014-05-26 15:25 ` James Bottomley
2014-05-27 8:06 ` Bart Van Assche
2014-05-27 8:09 ` James Bottomley
2014-05-27 8:36 ` Bart Van Assche
2014-05-27 8:56 ` James Bottomley
2014-05-27 9:06 ` Paolo Bonzini
2014-05-27 5:40 ` Hannes Reinecke
2014-05-27 6:08 ` Bart Van Assche
2014-05-27 6:22 ` Hannes Reinecke
2014-05-26 15:15 ` [PATCH 3/3] Make SCSI error handler code easier to understand Bart Van Assche
2014-05-27 5:42 ` Hannes Reinecke
2014-05-28 20:15 ` Joe Lawrence
2014-05-29 11:33 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53846D3E.6050901@redhat.com \
--to=pbonzini@redhat.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=jdl1291@gmail.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).