From: Boaz Harrosh <openosd@gmail.com>
To: Fabian Frederick <fabf@skynet.be>,
linux-scsi@vger.kernel.org,
James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Boaz Harrosh <bharrosh@panasas.com>,
Benny Halevy <bhalevy@primarydata.com>
Subject: Re: [PATCH 1/1] include/scsi/osd_protocol.h: remove unnecessary __constant
Date: Sun, 01 Jun 2014 18:47:13 +0300 [thread overview]
Message-ID: <538B4B01.1090805@gmail.com> (raw)
In-Reply-To: <1401631613-25359-1-git-send-email-fabf@skynet.be>
On 06/01/2014 05:06 PM, Fabian Frederick wrote:
> __constant_cpu_to_be16 converted to cpu_to_be16
>
> This patch fixes checkpatch warnings:
>
> "WARNING: __constant_cpu_to_be16 should be cpu_to_be16"
>
> Cc: Boaz Harrosh <bharrosh@panasas.com>
> Cc: Benny Halevy <bhalevy@primarydata.com>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Ack-by: Boaz Harrosh <bharrosh@panasas.com>
James please apply
Thanks
Boaz
> ---
> include/scsi/osd_protocol.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/scsi/osd_protocol.h b/include/scsi/osd_protocol.h
> index 25ac628..a2594af 100644
> --- a/include/scsi/osd_protocol.h
> +++ b/include/scsi/osd_protocol.h
> @@ -263,16 +263,16 @@ static inline struct osd_cdb_head *osd_cdb_head(struct osd_cdb *ocdb)
> * Ex name = FORMAT_OSD we have OSD_ACT_FORMAT_OSD && OSDv1_ACT_FORMAT_OSD
> */
> #define OSD_ACT___(Name, Num) \
> - OSD_ACT_##Name = __constant_cpu_to_be16(0x8880 + Num), \
> - OSDv1_ACT_##Name = __constant_cpu_to_be16(0x8800 + Num),
> + OSD_ACT_##Name = cpu_to_be16(0x8880 + Num), \
> + OSDv1_ACT_##Name = cpu_to_be16(0x8800 + Num),
>
> /* V2 only actions */
> #define OSD_ACT_V2(Name, Num) \
> - OSD_ACT_##Name = __constant_cpu_to_be16(0x8880 + Num),
> + OSD_ACT_##Name = cpu_to_be16(0x8880 + Num),
>
> #define OSD_ACT_V1_V2(Name, Num1, Num2) \
> - OSD_ACT_##Name = __constant_cpu_to_be16(Num2), \
> - OSDv1_ACT_##Name = __constant_cpu_to_be16(Num1),
> + OSD_ACT_##Name = cpu_to_be16(Num2), \
> + OSDv1_ACT_##Name = cpu_to_be16(Num1),
>
> enum osd_service_actions {
> OSD_ACT_V2(OBJECT_STRUCTURE_CHECK, 0x00)
>
prev parent reply other threads:[~2014-06-01 15:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-01 14:06 [PATCH 1/1] include/scsi/osd_protocol.h: remove unnecessary __constant Fabian Frederick
2014-06-01 15:47 ` Boaz Harrosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538B4B01.1090805@gmail.com \
--to=openosd@gmail.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bhalevy@primarydata.com \
--cc=bharrosh@panasas.com \
--cc=fabf@skynet.be \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).