From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ewan Milne <emilne@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 6/6] scsi_scan: Fixup scsilun_to_int()
Date: Mon, 02 Jun 2014 18:16:20 +0200 [thread overview]
Message-ID: <538CA354.8050002@acm.org> (raw)
In-Reply-To: <1401526878-119472-7-git-send-email-hare@suse.de>
On 05/31/14 11:01, Hannes Reinecke wrote:
> u64 scsilun_to_int(struct scsi_lun *scsilun)
> {
> - int i;
> - u64 lun;
> + const unsigned char * cp;
> + uint64_t res;
>
> - lun = 0;
> - for (i = 0; i < sizeof(lun); i += 2)
> - lun = lun | (((scsilun->scsi_lun[i] << 8) |
> - scsilun->scsi_lun[i + 1]) << (i * 8));
> - return lun;
> + res = (scsilun->scsi_lun[6] << 8) + scsilun->scsi_lun[7];
> + for (cp = scsilun->scsi_lun + 4; cp >= scsilun->scsi_lun; cp -= 2) {
> + res <<= 16;
> + res += (*cp << 8) + *(cp + 1);
> + }
> + return res;
> }
> EXPORT_SYMBOL(scsilun_to_int);
Has it been considered to use get_unaligned_be16(cp) instead of (*cp <<
8) + *(cp + 1) ? At least in my opinion the former is easier to read.
Bart.
next prev parent reply other threads:[~2014-06-02 16:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 9:01 [PATCHv3 0/6] Support 64-bit LUNs Hannes Reinecke
2014-05-31 9:01 ` [PATCH 1/6] scsi: Remove CONFIG_SCSI_MULTI_LUN Hannes Reinecke
2014-05-31 9:01 ` [PATCH 2/6] scsi_scan: Restrict sequential scan to 256 LUNs Hannes Reinecke
2014-05-31 9:01 ` [PATCH 3/6] qla2xxx: Restrict max_lun to 16-bit for older HBAs Hannes Reinecke
2014-05-31 9:01 ` [PATCH 4/6] scsi: use 64-bit LUNs Hannes Reinecke
2014-06-02 16:13 ` Bart Van Assche
2014-05-31 9:01 ` [PATCH 5/6] scsi: use 64-bit value for 'max_luns' Hannes Reinecke
2014-05-31 9:01 ` [PATCH 6/6] scsi_scan: Fixup scsilun_to_int() Hannes Reinecke
2014-06-02 16:03 ` James Bottomley
2014-06-02 16:16 ` Bart Van Assche [this message]
2014-06-02 8:15 ` [PATCHv3 0/6] Support 64-bit LUNs Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-06-03 8:58 [PATCHv4 " Hannes Reinecke
2014-06-03 8:58 ` [PATCH 6/6] scsi_scan: Fixup scsilun_to_int() Hannes Reinecke
2014-06-10 11:37 ` Bart Van Assche
2014-06-10 13:41 ` Douglas Gilbert
2014-06-10 14:06 ` James Bottomley
2014-06-10 14:48 ` Bart Van Assche
2014-06-10 15:01 ` James Bottomley
2014-06-10 16:08 ` Bart Van Assche
2014-06-10 14:55 ` Douglas Gilbert
2014-06-25 11:20 Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538CA354.8050002@acm.org \
--to=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).