From: Paolo Bonzini <pbonzini@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: hch@lst.de, JBottomley@Parallels.com, venkateshs@google.com
Subject: Re: [PATCH v2 0/6] virtio-scsi patches for 3.16 + midlayer fix
Date: Wed, 04 Jun 2014 13:33:04 +0200 [thread overview]
Message-ID: <538F03F0.8050506@redhat.com> (raw)
In-Reply-To: <538F0127.9040300@acm.org>
Il 04/06/2014 13:21, Bart Van Assche ha scritto:
>
> Thanks for the quick respin. However, since you are mentioning that in
> v2 all occurrences of "scmd->result |= DID_TIME_OUT << 16" have been
> addressed, this made me wonder whether you had noticed the following
> code in scsi_decide_disposition() ?
>
> switch (host_byte(scmd->result)) {
> [ ... ]
> case DID_ABORT:
> if (scmd->eh_eflags & SCSI_EH_ABORT_SCHEDULED) {
> scmd->result |= DID_TIME_OUT << 16;
> return SUCCESS;
> }
Nope, I miscounted how many occurrences were left. v3 on the way.
Paolo
prev parent reply other threads:[~2014-06-04 11:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 10:11 [PATCH v2 0/6] virtio-scsi patches for 3.16 + midlayer fix Paolo Bonzini
2014-06-04 10:11 ` [PATCH v2 1/6] virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends() Paolo Bonzini
2014-06-04 10:11 ` [PATCH v2 2/6] virtio-scsi: replace target spinlock with seqcount Paolo Bonzini
2014-06-04 17:24 ` Venkatesh Srinivas
2014-06-04 10:11 ` [PATCH v2 3/6] virtio-scsi: avoid cancelling uninitialized work items Paolo Bonzini
2014-06-04 10:11 ` [PATCH v2 4/6] scsi_error: fix invalid setting of host byte Paolo Bonzini
2014-06-04 10:11 ` [PATCH v2 5/6] virtio-scsi: fix various bad behavior on aborted requests Paolo Bonzini
2014-06-04 10:11 ` [PATCH v2 6/6] virtio-scsi: Implement change_queue_depth for virtscsi targets Paolo Bonzini
2014-06-04 11:21 ` [PATCH v2 0/6] virtio-scsi patches for 3.16 + midlayer fix Bart Van Assche
2014-06-04 11:33 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538F03F0.8050506@redhat.com \
--to=pbonzini@redhat.com \
--cc=JBottomley@Parallels.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=venkateshs@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).