From: Paolo Bonzini <pbonzini@redhat.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: "Nicholas A. Bellinger" <nab@daterainc.com>,
target-devel <target-devel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Sagi Grimberg <sagig@mellanox.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support
Date: Tue, 10 Jun 2014 10:03:39 +0200 [thread overview]
Message-ID: <5396BBDB.5070107@redhat.com> (raw)
In-Reply-To: <1402384060.5774.14.camel@haakon3.risingtidesystems.com>
Il 10/06/2014 09:07, Nicholas A. Bellinger ha scritto:
>> > OK, finally went over this, looks good to me:
>> >
>> > Acked-by: Michael S. Tsirkin <mst@redhat.com>
>> >
>> > However, we really should stop making more changes
>> > before fixing ANY_LAYOUT in this driver.
>> >
>> > virtio 1.0 should be out soon and that makes ANY_LAYOUT
>> > a required feature.
>> >
> What else is required to complete the ANY_LAYOUT conversion..?
Basically, you need to stop expecting the request and response headers
to be in a separate iov, and also vhost-scsi should not expect pi to be
in a separate iov than the main data. A layout that has everything in
the same iov would be fine, and similarly for a layout that has the CDB
in a separate iov than the rest of the header.
Paolo
next prev parent reply other threads:[~2014-06-10 8:03 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 2:26 [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support Nicholas A. Bellinger
2014-05-22 2:26 ` [PATCH-v2 1/6] virtio-scsi.h: Add virtio_scsi_cmd_req_pi + VIRTIO_SCSI_F_T10_PI bits Nicholas A. Bellinger
2014-05-22 6:57 ` Michael S. Tsirkin
2014-05-22 11:00 ` Rusty Russell
2014-05-22 20:38 ` Nicholas A. Bellinger
2014-06-09 13:16 ` Michael S. Tsirkin
2014-05-22 2:26 ` [PATCH-v2 2/6] vhost/scsi: Move sanity check into vhost_scsi_map_iov_to_sgl Nicholas A. Bellinger
2014-05-22 2:26 ` [PATCH-v2 3/6] vhost/scsi: Add preallocation of protection SGLs Nicholas A. Bellinger
2014-05-22 2:26 ` [PATCH-v2 4/6] vhost/scsi: Add T10 PI IOV -> SGL memory mapping logic Nicholas A. Bellinger
2014-05-22 2:26 ` [PATCH-v2 5/6] vhost/scsi: Enable T10 PI IOV -> SGL memory mapping Nicholas A. Bellinger
2014-06-09 13:15 ` Michael S. Tsirkin
2014-05-22 2:26 ` [PATCH-v2 6/6] virtio-scsi: Enable DIF/DIX modes in SCSI host LLD Nicholas A. Bellinger
2014-05-22 8:37 ` Paolo Bonzini
2014-05-22 20:41 ` Nicholas A. Bellinger
2014-05-22 8:37 ` [PATCH-v2 0/6] vhost/scsi: Add T10 PI SGL passthrough support Paolo Bonzini
2014-06-02 7:31 ` Michael S. Tsirkin
2014-06-08 16:05 ` Michael S. Tsirkin
2014-06-09 9:06 ` Paolo Bonzini
2014-06-10 7:07 ` Nicholas A. Bellinger
2014-06-10 8:03 ` Paolo Bonzini [this message]
2014-06-09 13:30 ` Michael S. Tsirkin
2014-06-10 7:05 ` Nicholas A. Bellinger
2014-06-10 9:42 ` Michael S. Tsirkin
2014-06-10 11:52 ` Stephen Rothwell
2014-06-10 13:02 ` Michael S. Tsirkin
2014-06-10 15:47 ` Stephen Rothwell
2014-06-10 17:39 ` Nicholas A. Bellinger
2014-06-10 18:45 ` Michael S. Tsirkin
2014-06-10 19:57 ` Nicholas A. Bellinger
2014-06-10 20:09 ` James Bottomley
2014-06-10 20:25 ` Nicholas A. Bellinger
2014-06-10 20:56 ` Linus Torvalds
2014-06-10 21:20 ` Nicholas A. Bellinger
2014-06-11 8:04 ` Michael S. Tsirkin
2014-06-10 19:35 ` Michael S. Tsirkin
2014-06-10 19:53 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5396BBDB.5070107@redhat.com \
--to=pbonzini@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=hpa@zytor.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mst@redhat.com \
--cc=nab@daterainc.com \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).