From: Mike Christie <michaelc@cs.wisc.edu>
To: Sagi Grimberg <sagig@mellanox.com>
Cc: martin.petersen@oracle.com, nab@linux-iscsi.org,
roland@kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v1 2/3] libiscsi, iser: Adjust data_length to include protection information
Date: Tue, 10 Jun 2014 13:19:35 -0500 [thread overview]
Message-ID: <53974C37.60206@cs.wisc.edu> (raw)
In-Reply-To: <1402223228-23768-3-git-send-email-sagig@mellanox.com>
On 06/08/2014 05:27 AM, Sagi Grimberg wrote:
> In case protection information exists over the wire
> iscsi header data_length is required to include it.
> Use protection information aware scsi helpers to set
> the correct transfer length.
>
> In order to avoid breakage, remove iser transfer length
> checks for each task as they are not always true and
> somewhat redundant anyway.
>
> Signed-off-by: Sagi Grimberg <sagig@mellanox.com>
> ---
> drivers/infiniband/ulp/iser/iser_initiator.c | 34 +++++++------------------
> drivers/scsi/libiscsi.c | 18 +++++++-------
Looks ok to me now. Thanks.
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Not sure, if I am supposed to do a acked-by for the libiscsi.c change,
but if so
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
next prev parent reply other threads:[~2014-06-10 18:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-08 10:27 [PATCH v1 0/3] Include protection information in iscsi header Sagi Grimberg
2014-06-08 10:27 ` [PATCH v1 1/3] scsi_cmnd: Introduce scsi_transfer_length helper Sagi Grimberg
[not found] ` <1402223228-23768-2-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-06-10 19:02 ` Martin K. Petersen
2014-06-10 19:16 ` Sagi Grimberg
[not found] ` <yq1fvjcvb8f.fsf-+q57XtR/GgMb6DWv4sQWN6xOck334EZe@public.gmane.org>
2014-06-10 20:19 ` Or Gerlitz
2014-06-10 20:21 ` Martin K. Petersen
2014-06-08 10:27 ` [PATCH v1 3/3] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire Sagi Grimberg
2014-06-10 8:04 ` Nicholas A. Bellinger
2014-06-10 8:12 ` Paolo Bonzini
2014-06-10 21:17 ` Quinn Tran
2014-06-11 7:24 ` Sagi Grimberg
2014-06-11 21:30 ` Nicholas A. Bellinger
2014-06-11 22:32 ` Quinn Tran
[not found] ` <504EB66DAC8D234EB8E8560985C2D7AD46D1D8C7-vcA9p2Eq0686wu3ARrlbmA@public.gmane.org>
2014-06-12 4:01 ` Nicholas A. Bellinger
[not found] ` <1402522215.17740.29.camel-XoQW25Eq2zviZyQQd+hFbcojREIfoBdhmpATvIKMPHk@public.gmane.org>
2014-06-11 23:20 ` Martin K. Petersen
[not found] ` <1402223228-23768-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2014-06-08 10:27 ` [PATCH v1 2/3] libiscsi, iser: Adjust data_length to include protection information Sagi Grimberg
2014-06-10 18:19 ` Mike Christie [this message]
2014-06-10 8:10 ` [PATCH v1 0/3] Include protection information in iscsi header Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53974C37.60206@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).