From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian King Subject: Re: [PATCHv2 1/2] ibmvscsi: Abort init sequence during error recovery Date: Fri, 13 Jun 2014 10:30:21 -0500 Message-ID: <539B190D.2040509@linux.vnet.ibm.com> References: <201405231552.s4NFqA9C027982@d01av01.pok.ibm.com> <53849960.60505@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from e33.co.us.ibm.com ([32.97.110.151]:46525 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752906AbaFMPa1 (ORCPT ); Fri, 13 Jun 2014 11:30:27 -0400 Received: from /spool/local by e33.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 13 Jun 2014 09:30:26 -0600 Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id CE12B1FF0040 for ; Fri, 13 Jun 2014 09:30:23 -0600 (MDT) Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by b03cxnp08025.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s5DFUOhm131546 for ; Fri, 13 Jun 2014 17:30:24 +0200 Received: from d03av03.boulder.ibm.com (localhost [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s5DFUM0O003961 for ; Fri, 13 Jun 2014 09:30:23 -0600 In-Reply-To: <53849960.60505@linux.vnet.ibm.com> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: James.Bottomley@HansenPartnership.com Cc: Nathan Fontenot , linux-scsi@vger.kernel.org On 05/27/2014 08:55 AM, Nathan Fontenot wrote: > On 05/23/2014 10:52 AM, Brian King wrote: >> If a CRQ reset is triggered for some reason while in the middle >> of performing VSCSI adapter initialization, we don't want to >> call the done function for the initialization MAD commands as >> this will only result in two threads attempting initialization >> at the same time, resulting in failures. >> >> Signed-off-by: Brian King > > Acked-by: Nathan Fontenot > >> --- >> >> drivers/scsi/ibmvscsi/ibmvscsi.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff -puN drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_purge_fix drivers/scsi/ibmvscsi/ibmvscsi.c >> --- linux/drivers/scsi/ibmvscsi/ibmvscsi.c~ibmvscsi_purge_fix 2014-05-23 10:36:04.000000000 -0500 >> +++ linux-bjking1/drivers/scsi/ibmvscsi/ibmvscsi.c 2014-05-23 10:50:03.000000000 -0500 >> @@ -797,7 +797,8 @@ static void purge_requests(struct ibmvsc >> evt->hostdata->dev); >> if (evt->cmnd_done) >> evt->cmnd_done(evt->cmnd); >> - } else if (evt->done) >> + } else if (evt->done && evt->crq.format != VIOSRP_MAD_FORMAT && >> + evt->iu.srp.login_req.opcode != SRP_LOGIN_REQ) >> evt->done(evt); >> free_event_struct(&evt->hostdata->pool, evt); >> spin_lock_irqsave(hostdata->host->host_lock, flags); >> _ Hi James, Are these two patches in your queue? They both fix rather nasty issues that have caused kernel crashes in our testing. Thanks, Brian