* [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
@ 2014-06-26 11:54 Rickard Strandqvist
2014-06-26 12:05 ` Joe Perches
2014-06-26 12:14 ` Maurizio Lombardi
0 siblings, 2 replies; 5+ messages in thread
From: Rickard Strandqvist @ 2014-06-26 11:54 UTC (permalink / raw)
To: Eddie Wai, James E.J. Bottomley
Cc: Rickard Strandqvist, linux-scsi, linux-kernel
A struct member variable is set to different values without having used in between.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
index 166543f..4e17a7f 100644
--- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
+++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
@@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
stats->r2t_pdus = conn->r2t_pdus_cnt;
stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
- stats->custom_length = 3;
strcpy(stats->custom[2].desc, "eh_abort_cnt");
stats->custom[2].value = conn->eh_abort_cnt;
stats->digest_err = 0;
stats->timeout_err = 0;
- stats->custom_length = 0;
+ stats->custom_length = 3;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
2014-06-26 11:54 [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once Rickard Strandqvist
@ 2014-06-26 12:05 ` Joe Perches
2014-06-26 12:12 ` Maurizio Lombardi
2014-06-26 12:14 ` Maurizio Lombardi
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2014-06-26 12:05 UTC (permalink / raw)
To: Rickard Strandqvist
Cc: Eddie Wai, James E.J. Bottomley, linux-scsi, linux-kernel
On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in between.
[]
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
[]
> @@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> stats->r2t_pdus = conn->r2t_pdus_cnt;
> stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
> stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
> - stats->custom_length = 3;
> strcpy(stats->custom[2].desc, "eh_abort_cnt");
> stats->custom[2].value = conn->eh_abort_cnt;
> stats->digest_err = 0;
> stats->timeout_err = 0;
> - stats->custom_length = 0;
> + stats->custom_length = 3;
You are changing custom_length from 0 to 3.
Why is this correct?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
2014-06-26 12:05 ` Joe Perches
@ 2014-06-26 12:12 ` Maurizio Lombardi
2014-06-26 12:17 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Maurizio Lombardi @ 2014-06-26 12:12 UTC (permalink / raw)
To: Joe Perches, Rickard Strandqvist
Cc: Eddie Wai, James E.J. Bottomley, linux-scsi, linux-kernel
On 06/26/2014 02:05 PM, Joe Perches wrote:
> On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
>> A struct member variable is set to different values without having used in between.
> []
>> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> []
>> @@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
>> stats->r2t_pdus = conn->r2t_pdus_cnt;
>> stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
>> stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
>> - stats->custom_length = 3;
>> strcpy(stats->custom[2].desc, "eh_abort_cnt");
>> stats->custom[2].value = conn->eh_abort_cnt;
>> stats->digest_err = 0;
>> stats->timeout_err = 0;
>> - stats->custom_length = 0;
>> + stats->custom_length = 3;
>
> You are changing custom_length from 0 to 3.
>
> Why is this correct?
http://marc.info/?l=linux-scsi&m=140371670511706&w=2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
2014-06-26 12:12 ` Maurizio Lombardi
@ 2014-06-26 12:17 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2014-06-26 12:17 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: Rickard Strandqvist, Eddie Wai, James E.J. Bottomley, linux-scsi,
linux-kernel
On Thu, 2014-06-26 at 14:12 +0200, Maurizio Lombardi wrote:
>
> On 06/26/2014 02:05 PM, Joe Perches wrote:
> > On Thu, 2014-06-26 at 13:54 +0200, Rickard Strandqvist wrote:
> >> A struct member variable is set to different values without having used in between.
> > []
> >> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> > []
> >> @@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> >> stats->r2t_pdus = conn->r2t_pdus_cnt;
> >> stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
> >> stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
> >> - stats->custom_length = 3;
> >> strcpy(stats->custom[2].desc, "eh_abort_cnt");
> >> stats->custom[2].value = conn->eh_abort_cnt;
> >> stats->digest_err = 0;
> >> stats->timeout_err = 0;
> >> - stats->custom_length = 0;
> >> + stats->custom_length = 3;
> >
> > You are changing custom_length from 0 to 3.
> >
> > Why is this correct?
>
> http://marc.info/?l=linux-scsi&m=140371670511706&w=2
Then the subject and commit message are wrong and need
to be updated to reflect your text.
This is a bugfix, not a cleanup.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once
2014-06-26 11:54 [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-26 12:05 ` Joe Perches
@ 2014-06-26 12:14 ` Maurizio Lombardi
1 sibling, 0 replies; 5+ messages in thread
From: Maurizio Lombardi @ 2014-06-26 12:14 UTC (permalink / raw)
To: Rickard Strandqvist, Eddie Wai, James E.J. Bottomley
Cc: linux-scsi, linux-kernel
On 06/26/2014 01:54 PM, Rickard Strandqvist wrote:
> A struct member variable is set to different values without having used in between.
It is almost ok for me but I think you should mention that it also fixes a bug,
or the commit message will be misleading.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/scsi/bnx2i/bnx2i_iscsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2i/bnx2i_iscsi.c b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> index 166543f..4e17a7f 100644
> --- a/drivers/scsi/bnx2i/bnx2i_iscsi.c
> +++ b/drivers/scsi/bnx2i/bnx2i_iscsi.c
> @@ -1643,12 +1643,11 @@ static void bnx2i_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> stats->r2t_pdus = conn->r2t_pdus_cnt;
> stats->tmfcmd_pdus = conn->tmfcmd_pdus_cnt;
> stats->tmfrsp_pdus = conn->tmfrsp_pdus_cnt;
> - stats->custom_length = 3;
> strcpy(stats->custom[2].desc, "eh_abort_cnt");
> stats->custom[2].value = conn->eh_abort_cnt;
> stats->digest_err = 0;
> stats->timeout_err = 0;
> - stats->custom_length = 0;
> + stats->custom_length = 3;
> }
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-26 12:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 11:54 [PATCH v2] scsi: bnx2i: bnx2i_iscsi.c: Cleaning up variable is set more than once Rickard Strandqvist
2014-06-26 12:05 ` Joe Perches
2014-06-26 12:12 ` Maurizio Lombardi
2014-06-26 12:17 ` Joe Perches
2014-06-26 12:14 ` Maurizio Lombardi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox