From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
James Bottomley <jbottomley@parallels.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 4/4] scsi_scan: Fixup scsilun_to_int()
Date: Fri, 27 Jun 2014 09:12:32 +0200 [thread overview]
Message-ID: <53AD1960.70703@acm.org> (raw)
In-Reply-To: <1403702859-74437-5-git-send-email-hare@suse.de>
On 06/25/14 15:27, Hannes Reinecke wrote:
> scsilun_to_int() has an error which prevents it from generating
> correct LUN numbers for 64bit values.
> Also we should remove the misleading comment about portions of
> the LUN being ignored; the initiator should treat the LUN as
> an opaque value.
> And, finally, the example given should use the correct
> prefix (here: extended flat space addressing scheme).
I'm still not enthusiast about the byte reordering by scsilun_to_int()
for extended logical unit addressing. But I can confirm that this patch
passed the test that failed with the previous version of the 64-bit LUN
patch series. So if you want you can add "Tested-by: Bart van Assche
<bvanassche@acm.org>".
Best regards,
Bart.
next prev parent reply other threads:[~2014-06-27 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 13:27 [PATCHv5 0/4] Support 64-bit LUNs Hannes Reinecke
2014-06-25 13:27 ` [PATCH 1/4] scsi: use " Hannes Reinecke
2014-06-25 13:27 ` [PATCH 2/4] Add module param type 'ullong' Hannes Reinecke
2014-06-25 13:27 ` [PATCH 3/4] scsi: use 64-bit value for 'max_luns' Hannes Reinecke
2014-06-25 13:27 ` [PATCH 4/4] scsi_scan: Fixup scsilun_to_int() Hannes Reinecke
2014-06-27 7:12 ` Bart Van Assche [this message]
2014-06-27 7:30 ` Hannes Reinecke
2014-06-27 12:49 ` Bart Van Assche
2014-06-25 15:00 ` [PATCHv5 0/4] Support 64-bit LUNs Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD1960.70703@acm.org \
--to=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox