Re: [PATCH 0/5] SRP initiator patches for kernel 3.17

Re: [PATCH 0/5] SRP initiator patches for kernel 3.17

[Bart Van Assche]

(CC-ing linux-scsi)

On 07/03/14 15:44, Bart Van Assche wrote:
> This patch series consists of the following five patches, of which three
> are bug fixes and two are performance optimizations:
> 
> 0001-scsi_transport_srp-Fix-fast_io_fail_tmo-dev_loss_tmo.patch
> 0002-IB-srp-Fix-deadlock-between-host-removal-and-multipa.patch
> 0003-IB-srp-Fix-residual-handling.patch
> 0004-IB-srp-Use-P_Key-cache-for-P_Key-lookups.patch
> 0005-IB-srp-Optimize-completion-queue-polling.patch
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> .
> 

Re: [PATCH 0/5] SRP initiator patches for kernel 3.17

[Bart Van Assche]

(CC'ing linux-scsi)

On 07/03/14 15:45, Bart Van Assche wrote:> If scsi_remove_host() is called while an rport is in the blocked
> state then scsi_remove_host() will only finish if the rport is
> unblocked from inside a timer function. Make sure that an rport
> only enters the blocked state if a timer will be started that
> will unblock it. This avoids that unloading the ib_srp kernel
> module after having disconnected the initiator from the target
> system results in a deadlock if both the fast_io_fail_tmo and
> dev_loss_tmo parameters have been set to "off".
> 
> Signed-off-by: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
> Cc: James Bottomley <jbottomley-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
> Cc: Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Cc: Sebastian Parschauer <sebastian.riemer-EIkl63zCoXaH+58JC4qpiA@public.gmane.org>
> Cc: David Dillow <dave-i1Mk8JYDVaaSihdK6806/g@public.gmane.org>
> Cc: <stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
> ---
>  drivers/scsi/scsi_transport_srp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_transport_srp.c b/drivers/scsi/scsi_transport_srp.c
> index 13e8983..a0c5bfd 100644
> --- a/drivers/scsi/scsi_transport_srp.c
> +++ b/drivers/scsi/scsi_transport_srp.c
> @@ -473,7 +473,8 @@ static void __srp_start_tl_fail_timers(struct srp_rport *rport)
>  	if (delay > 0)
>  		queue_delayed_work(system_long_wq, &rport->reconnect_work,
>  				   1UL * delay * HZ);
> -	if (srp_rport_set_state(rport, SRP_RPORT_BLOCKED) == 0) {
> +	if ((fast_io_fail_tmo >= 0 || dev_loss_tmo >= 0) &&
> +	    srp_rport_set_state(rport, SRP_RPORT_BLOCKED) == 0) {
>  		pr_debug("%s new state: %d\n", dev_name(&shost->shost_gendev),
>  			 rport->state);
>  		scsi_target_block(&shost->shost_gendev);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/5] SRP initiator patches for kernel 3.17

[Sagi Grimberg]

On 7/3/2014 5:17 PM, Bart Van Assche wrote:
>> This patch series consists of the following five patches, of which three
>> are bug fixes and two are performance optimizations:
>>
>> 0001-scsi_transport_srp-Fix-fast_io_fail_tmo-dev_loss_tmo.patch
>> 0002-IB-srp-Fix-deadlock-between-host-removal-and-multipa.patch
>> 0003-IB-srp-Fix-residual-handling.patch
>> 0004-IB-srp-Use-P_Key-cache-for-P_Key-lookups.patch
>> 0005-IB-srp-Optimize-completion-queue-polling.patch
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> .
>>

Hey Bart,

The series looks good,

You can add to the series:
Reviewed-by: Sagi Grimberg <sagig@mellanox.com>

Specifically to patches #1, #4, #5 you can add:
Tested-by: Sagi Grimberg <sagig@mellanox.com>

Sagi.