Re: [PATCH] scsi: break from queue depth adjusting loops when device found

[Douglas Gilbert <dgilbert@interlog.com>]

On 14-07-03 11:05 AM, Stephen M. Cameron wrote:
> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>
> Don't loop through all the devices even after
> finding the one we're looking for
>
> Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
> Reviewed-by: Robert Elliott <elliott@hp.com>

With my scsi_debug testing on Christoph's core-for-3.17
tree I can simulate infrequent TSF conditions using the
every_nth mechanism. When one is triggered, all scsi
devices (that scsi_debug is monitoring) get their
queue_depth adjusted.

So:
Acked-by: Douglas Gilbert <dgilbert@interlog.com>


> ---
>   drivers/scsi/scsi_error.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index cbe38e5..db8a488 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -635,6 +635,7 @@ static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
>   		sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth + 1,
>   					SCSI_QDEPTH_RAMP_UP);
>   		sdev->last_queue_ramp_up = jiffies;
> +		break;
>   	}
>   }
>
> @@ -657,6 +658,7 @@ static void scsi_handle_queue_full(struct scsi_device *sdev)
>   		 */
>   		sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth - 1,
>   					SCSI_QDEPTH_QFULL);
> +		break;
>   	}
>   }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>