From: Douglas Gilbert <dgilbert@interlog.com>
To: Mike Christie <michaelc@cs.wisc.edu>, Christoph Hellwig <hch@lst.de>
Cc: "Stephen M. Cameron" <scameron@beardog.cce.hp.com>,
james.bottomley@parallels.com, elliott@hp.com,
stephenmcameron@gmail.com, linux-scsi@vger.kernel.org,
Vasu Dev <vasu.dev@linux.intel.com>,
James Smart <James.Smart@Emulex.Com>
Subject: Re: [PATCH] scsi: break from queue depth adjusting loops when device found
Date: Fri, 04 Jul 2014 14:36:28 -0400 [thread overview]
Message-ID: <53B6F42C.7030607@interlog.com> (raw)
In-Reply-To: <53B5910F.1080405@cs.wisc.edu>
On 14-07-03 01:21 PM, Mike Christie wrote:
> On 07/03/2014 12:11 PM, Christoph Hellwig wrote:
>> On Thu, Jul 03, 2014 at 10:05:57AM -0500, Stephen M. Cameron wrote:
>>> From: Stephen M. Cameron <scameron@beardog.cce.hp.com>
>>>
>>> Don't loop through all the devices even after
>>> finding the one we're looking for
>>
>> The comments in the code seem to indicate that we want to modify
>> the queue depth for all LUNs on a given target.
>>
>> Ccing Mike and Vasu as they wrote this code.
>>
>
> Ccing James Smart for more details.
>
> We copied this behavior from lpfc's SAM_STAT_TASK_SET_FULL handling
> (look at around the 2.6.32 kernel for reference).
Perhaps there should be a knob to control this, maybe within
the scope of a host. I have one RAID controller that has a
JBOD mode in which real disks are presented as LUs in the same
target. Obviously the TSF (queue_type and other) capabilities
of those real disks might differ.
Doug Gilbert
next prev parent reply other threads:[~2014-07-04 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-03 15:05 [PATCH] scsi: break from queue depth adjusting loops when device found Stephen M. Cameron
2014-07-03 15:25 ` Douglas Gilbert
2014-07-03 17:11 ` Christoph Hellwig
2014-07-03 17:21 ` Mike Christie
2014-07-04 18:36 ` Douglas Gilbert [this message]
2014-07-04 10:53 ` Hannes Reinecke
2014-07-04 19:21 ` Elliott, Robert (Server Storage)
2014-07-06 9:49 ` Christoph Hellwig
2014-07-26 15:36 ` Christoph Hellwig
[not found] ` <CADzpL0Rn+x6N=v123EBej_iZhTwmjMYZ4deeTeRG7_sxgXU9PQ@mail.gmail.com>
2014-07-26 16:17 ` Christoph Hellwig
2014-07-27 15:36 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B6F42C.7030607@interlog.com \
--to=dgilbert@interlog.com \
--cc=James.Smart@Emulex.Com \
--cc=elliott@hp.com \
--cc=hch@lst.de \
--cc=james.bottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=scameron@beardog.cce.hp.com \
--cc=stephenmcameron@gmail.com \
--cc=vasu.dev@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox