Re: [PATCH 1/2] Use sdev_scsi2lun for SCSI parallel drivers

Christoph Hellwig
2014-07-07T10:11:22Z

On Mon, Jul 07, 2014 at 12:05:04PM +0200, Hannes Reinecke wrote:
> Ok, so I'll be sending a patchset for fixing up the build warnings
> (and keeping the current accesses to ->lun), and prepare a different
> patchset moving everything onto accessors so that we can use struct scsi_lun
> directly.
> Agreed?

That would be my preference, yes.

Btw, re the build warnings: what's the reason you prefer casts to u8
over just using the %lld printk specifier? Avoiding casts generally
seems to be the cleaner variant to me.