From: Tomas Henzl <thenzl@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Maurizio Lombardi <mlombard@redhat.com>,
jayamohan.kallickal@emulex.com, linux-scsi@vger.kernel.org,
michaelc@cs.wisc.edu, JBottomley@parallels.com
Subject: Re: [PATCH] b2iscsi: Fix memory leak in mgmt_set_ip()
Date: Mon, 07 Jul 2014 13:29:25 +0200 [thread overview]
Message-ID: <53BA8495.5080708@redhat.com> (raw)
In-Reply-To: <20140701185333.GA7225@infradead.org>
On 07/01/2014 08:53 PM, Christoph Hellwig wrote:
> On Sun, Jun 29, 2014 at 08:28:34PM +0200, Tomas Henzl wrote:
>> On 06/27/2014 09:38 PM, Maurizio Lombardi wrote:
>>>>> diff --git a/drivers/scsi/be2iscsi/be_mgmt.c b/drivers/scsi/be2iscsi/be_mgmt.c
>>>>> index 07934b0..a3e5648 100644
>>>>> --- a/drivers/scsi/be2iscsi/be_mgmt.c
>>>>> +++ b/drivers/scsi/be2iscsi/be_mgmt.c
>>>>> @@ -1015,7 +1015,7 @@ int mgmt_set_ip(struct beiscsi_hba *phba,
>>>>> if (if_info->dhcp_state) {
>>>>> beiscsi_log(phba, KERN_WARNING, BEISCSI_LOG_CONFIG,
>>>>> "BG_%d : DHCP Already Enabled\n");
>>>>> - return 0;
>>>>> + goto exit;
>>>> rc should be initialised - so this needs to be added to your patch
>>> It is initialized at the beginning of the function, and it must contain zero when the "goto exit" is executed.
>> Correct, I haven't noticed the initialisation, sorry for the confusion.
> Is this a formal review from you?
I was under time pressure so I just wanted to remove my previous negative comment, but now -
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
prev parent reply other threads:[~2014-07-07 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 12:55 [PATCH] b2iscsi: Fix memory leak in mgmt_set_ip() Maurizio Lombardi
2014-06-27 16:32 ` Tomas Henzl
2014-06-27 19:38 ` Maurizio Lombardi
2014-06-29 18:28 ` Tomas Henzl
2014-07-01 18:53 ` Christoph Hellwig
2014-07-07 11:29 ` Tomas Henzl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BA8495.5080708@redhat.com \
--to=thenzl@redhat.com \
--cc=JBottomley@parallels.com \
--cc=hch@infradead.org \
--cc=jayamohan.kallickal@emulex.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=mlombard@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox