* [PATCH] beiscsi: the custom_length field has been set to a wrong value.
@ 2014-06-26 9:16 Maurizio Lombardi
2014-07-07 13:57 ` Christoph Hellwig
2014-07-07 15:35 ` Tomas Henzl
0 siblings, 2 replies; 4+ messages in thread
From: Maurizio Lombardi @ 2014-06-26 9:16 UTC (permalink / raw)
To: jayamohan.kallickal; +Cc: linux-scsi, michaelc, hch, JBottomley
In the beiscsi_conn_get_stats() function, custom_length should be set
to 1 to take into account the "eh_abort_cnt" field at custom[0].
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
index fd284ff..8616281 100644
--- a/drivers/scsi/be2iscsi/be_iscsi.c
+++ b/drivers/scsi/be2iscsi/be_iscsi.c
@@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn *cls_conn,
stats->r2t_pdus = conn->r2t_pdus_cnt;
stats->digest_err = 0;
stats->timeout_err = 0;
- stats->custom_length = 0;
+ stats->custom_length = 1;
strcpy(stats->custom[0].desc, "eh_abort_cnt");
stats->custom[0].value = conn->eh_abort_cnt;
}
--
Maurizio Lombardi
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
2014-06-26 9:16 [PATCH] beiscsi: the custom_length field has been set to a wrong value Maurizio Lombardi
@ 2014-07-07 13:57 ` Christoph Hellwig
2014-07-07 15:35 ` Tomas Henzl
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2014-07-07 13:57 UTC (permalink / raw)
To: Maurizio Lombardi
Cc: jayamohan.kallickal, linux-scsi, michaelc, JBottomley,
Tomas Henzl
On Thu, Jun 26, 2014 at 11:16:26AM +0200, Maurizio Lombardi wrote:
> In the beiscsi_conn_get_stats() function, custom_length should be set
> to 1 to take into account the "eh_abort_cnt" field at custom[0].
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Any chance to get a review on this one?
> ---
> drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
> index fd284ff..8616281 100644
> --- a/drivers/scsi/be2iscsi/be_iscsi.c
> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
> @@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> stats->r2t_pdus = conn->r2t_pdus_cnt;
> stats->digest_err = 0;
> stats->timeout_err = 0;
> - stats->custom_length = 0;
> + stats->custom_length = 1;
> strcpy(stats->custom[0].desc, "eh_abort_cnt");
> stats->custom[0].value = conn->eh_abort_cnt;
> }
> --
> Maurizio Lombardi
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
---end quoted text---
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
2014-06-26 9:16 [PATCH] beiscsi: the custom_length field has been set to a wrong value Maurizio Lombardi
2014-07-07 13:57 ` Christoph Hellwig
@ 2014-07-07 15:35 ` Tomas Henzl
2014-07-07 15:52 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Tomas Henzl @ 2014-07-07 15:35 UTC (permalink / raw)
To: Maurizio Lombardi, jayamohan.kallickal
Cc: linux-scsi, michaelc, hch, JBottomley
On 06/26/2014 11:16 AM, Maurizio Lombardi wrote:
> In the beiscsi_conn_get_stats() function, custom_length should be set
> to 1 to take into account the "eh_abort_cnt" field at custom[0].
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/scsi/be2iscsi/be_iscsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_iscsi.c b/drivers/scsi/be2iscsi/be_iscsi.c
> index fd284ff..8616281 100644
> --- a/drivers/scsi/be2iscsi/be_iscsi.c
> +++ b/drivers/scsi/be2iscsi/be_iscsi.c
> @@ -914,7 +914,7 @@ void beiscsi_conn_get_stats(struct iscsi_cls_conn *cls_conn,
> stats->r2t_pdus = conn->r2t_pdus_cnt;
> stats->digest_err = 0;
> stats->timeout_err = 0;
> - stats->custom_length = 0;
> + stats->custom_length = 1;
> strcpy(stats->custom[0].desc, "eh_abort_cnt");
> stats->custom[0].value = conn->eh_abort_cnt;
> }
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] beiscsi: the custom_length field has been set to a wrong value.
2014-07-07 15:35 ` Tomas Henzl
@ 2014-07-07 15:52 ` Christoph Hellwig
0 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2014-07-07 15:52 UTC (permalink / raw)
To: Tomas Henzl
Cc: Maurizio Lombardi, jayamohan.kallickal, linux-scsi, michaelc, hch,
JBottomley
Oops, I just noticed that
bnx2i, be2iscsi: fix custom stats length
included this one liner change. Sorry for the stir!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-07 15:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-26 9:16 [PATCH] beiscsi: the custom_length field has been set to a wrong value Maurizio Lombardi
2014-07-07 13:57 ` Christoph Hellwig
2014-07-07 15:35 ` Tomas Henzl
2014-07-07 15:52 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox