[PATCH] scsi: arm: fas216: Use %llu to print 'u64' format

[PATCH] scsi: arm: fas216: Use %llu to print 'u64' format

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

The following warning is seen when building for ARM:

drivers/scsi/arm/fas216.c:3003:3: warning: format '%d' expects argument of type
'int', but argument 4 has type 'u64' [-Wformat=]

Use %llu to print 'u64' format.

Reported-by: Olof's autobuilder <build@lixom.net>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/scsi/arm/fas216.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/arm/fas216.c b/drivers/scsi/arm/fas216.c
index b46a6f6..aeddd11 100644
--- a/drivers/scsi/arm/fas216.c
+++ b/drivers/scsi/arm/fas216.c
@@ -3000,7 +3000,7 @@ void fas216_print_devices(FAS216_Info *info, struct seq_file *m)
 
 	shost_for_each_device(scd, info->host) {
 		dev = &info->device[scd->id];
-		seq_printf(m, "     %d/%d   ", scd->id, scd->lun);
+		seq_printf(m, "     %d/%llu   ", scd->id, scd->lun);
 		if (scd->tagged_supported)
 			seq_printf(m, "%3sabled(%3d) ",
 				     scd->simple_tags ? "en" : "dis",
-- 
1.8.3.2

Re: [PATCH] scsi: arm: fas216: Use %llu to print 'u64' format

[Christoph Hellwig]

Thanks Fabio,

this looks good to me.  Are there any other warnings you got from that
autobuilder?

Re: [PATCH] scsi: arm: fas216: Use %llu to print 'u64' format

[Hannes Reinecke]

On 07/11/2014 08:23 AM, Christoph Hellwig wrote:
> Thanks Fabio,
>
> this looks good to me.  Are there any other warnings you got from that
> autobuilder?
>
It _should_ have been fixed with my latest patch for fixing the 
64bit LUN fallout. Christoph, have you applied it?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: arm: fas216: Use %llu to print 'u64' format

[Christoph Hellwig]

On Fri, Jul 11, 2014 at 08:30:17AM +0200, Hannes Reinecke wrote:
> On 07/11/2014 08:23 AM, Christoph Hellwig wrote:
> >Thanks Fabio,
> >
> >this looks good to me.  Are there any other warnings you got from that
> >autobuilder?
> >
> It _should_ have been fixed with my latest patch for fixing the 64bit LUN
> fallout. Christoph, have you applied it?

Looks like this is in, indeed.  Seems like that latest drivers-for-3.17
update hasn't made it into James' for-next and thus linux-next, though.

Re: [PATCH] scsi: arm: fas216: Use %llu to print 'u64' format

[Fabio Estevam]

Hi Christoph,

On Fri, Jul 11, 2014 at 3:23 AM, Christoph Hellwig <hch@infradead.org> wrote:
> Thanks Fabio,
>
> this looks good to me.  Are there any other warnings you got from that
> autobuilder?

Yes, the build results for various ARM defconfigs are available at:
http://lists.linaro.org/pipermail/kernel-build-reports/2014-July/004338.html

Regards,

Fabio Estevam