Re: [PATCH 08/10] sd: retry discard commands

[Hannes Reinecke <hare@suse.de>]

On 06/29/2014 03:34 PM, Christoph Hellwig wrote:
> Currently cmd->allowed is initialized from rq->retries for discard
> commands, but retries is always 0 for non-BLOCK_PC requests.  Set it
> to the standard number of retries instead.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/scsi/sd.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
> index 777b141..5f85102 100644
> --- a/drivers/scsi/sd.c
> +++ b/drivers/scsi/sd.c
> @@ -760,7 +760,7 @@ static int sd_setup_discard_cmnd(struct scsi_cmnd *cmd)
>   	blk_add_request_payload(rq, page, len);
>
>   	cmd->transfersize = len;
> -	cmd->allowed = rq->retries;
> +	cmd->allowed = SD_MAX_RETRIES;
>
>   	ret = scsi_init_io(cmd, GFP_ATOMIC);
>   	rq->__data_len = nr_bytes;
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html