Re: [PATCH 10/10] scsi: mark scsi_setup_blk_pc_cmnd static

[Hannes Reinecke <hare@suse.de>]

On 06/29/2014 03:34 PM, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>   drivers/scsi/scsi_lib.c    |    3 +--
>   include/scsi/scsi_driver.h |    2 --
>   2 files changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
> index ea23860..f0a3ef1 100644
> --- a/drivers/scsi/scsi_lib.c
> +++ b/drivers/scsi/scsi_lib.c
> @@ -1080,7 +1080,7 @@ static struct scsi_cmnd *scsi_get_cmd_from_req(struct scsi_device *sdev,
>   	return cmd;
>   }
>
> -int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req)
> +static int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req)
>   {
>   	struct scsi_cmnd *cmd = req->special;
>
> @@ -1105,7 +1105,6 @@ int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req)
>   	cmd->allowed = req->retries;
>   	return BLKPREP_OK;
>   }
> -EXPORT_SYMBOL(scsi_setup_blk_pc_cmnd);
>
>   /*
>    * Setup a REQ_TYPE_FS command.  These are simple request from filesystems
> diff --git a/include/scsi/scsi_driver.h b/include/scsi/scsi_driver.h
> index 009d2ae..c2b7598 100644
> --- a/include/scsi/scsi_driver.h
> +++ b/include/scsi/scsi_driver.h
> @@ -29,6 +29,4 @@ extern int scsi_register_interface(struct class_interface *);
>   #define scsi_unregister_interface(intf) \
>   	class_interface_unregister(intf)
>
> -int scsi_setup_blk_pc_cmnd(struct scsi_device *sdev, struct request *req);
> -
>   #endif /* _SCSI_SCSI_DRIVER_H */
>
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html