From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>,
"Reddy, Sreekanth" <Sreekanth.Reddy@avagotech.com>,
Sathya.Prakash@avagotech.com,
Nagalakshmi.Nandigama@avagotech.com
Cc: linux-scsi@vger.kernel.org
Subject: Re: mpt2sas and mpt3sas merge (again)
Date: Mon, 14 Jul 2014 11:22:56 +0200 [thread overview]
Message-ID: <53C3A170.1070101@suse.de> (raw)
In-Reply-To: <20140714083547.GA6315@infradead.org>
On 07/14/2014 10:35 AM, Christoph Hellwig wrote:
> Back when the mpt3sas driver was first posted I suggested that it should
> be merged into mpt2sas, but my proposal didn't get much traction.
>
> Illumos has now produced a shared driver and shown that the difference
> are basically limited to a different S/G list format [1], and a quick
> experiment on the Linux drivers confirms this mostly - the additional
> differences are various smaller workarounds for specific hardware
> revisions.
>
> I think we'd all be served much better with a merged driver.
>
> [1] http://thread.gmane.org/gmane.os.illumos.devel/17341
Please. Pretty please.
I've started a merge myself, but then never found time to finalize it.
Carrying three basically identical drivers just creates a
maintenance overhead for everyone involved.
The original idea of splitting the driver and just maintaining the
latest has never really worked out; all fixes to the latest driver
turned out to be applicable to the others, too.
So it just increased the workload for the maintainer for no real
gain. I would _strongly_ vote for it.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-14 9:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-14 8:35 mpt2sas and mpt3sas merge (again) Christoph Hellwig
2014-07-14 9:22 ` Hannes Reinecke [this message]
2014-07-14 14:17 ` James Bottomley
2014-07-14 14:39 ` Hannes Reinecke
2014-07-14 14:57 ` James Bottomley
2014-07-14 15:10 ` Hannes Reinecke
2014-07-14 17:00 ` Tomas Henzl
2014-07-14 21:34 ` Martin K. Petersen
[not found] ` <CAK=zhgoD9vVH0zCORTA2Mhu8Tf4m4VAih_hpig4PDdh-vgJmQg@mail.gmail.com>
2014-07-23 1:39 ` Martin K. Petersen
2014-07-24 12:25 ` Sreekanth Reddy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C3A170.1070101@suse.de \
--to=hare@suse.de \
--cc=Nagalakshmi.Nandigama@avagotech.com \
--cc=Sathya.Prakash@avagotech.com \
--cc=Sreekanth.Reddy@avagotech.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox