linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
	axboe@fb.com, nab@daterainc.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present
Date: Thu, 17 Jul 2014 13:48:01 +0200	[thread overview]
Message-ID: <53C7B7F1.2060005@acm.org> (raw)
In-Reply-To: <1401335565-29865-6-git-send-email-martin.petersen@oracle.com>

On 05/29/14 05:52, Martin K. Petersen wrote:
> Copy offloading requires us to know the NAA descriptor for both source
> target device. This descriptor is mandatory in the Device Identification
> VPD page. Locate this descriptor in the returned VPD data so we don't
> have to do lookups for every copy command.

Hello Martin,

Sorry for the late reply but it's only now that I noticed this patch.
Are you sure that presence of a NAA descriptor is mandatory ? This is
what I found in SPC-4 r37 paragraph 7.8.6.2.1:

<quote>
At least one designation descriptor should have the DESIGNATOR TYPE
field set to:
a) 2h (i.e., EUI-64-based);
b) 3h (i.e., NAA); or
c) 8h (i.e., SCSI name string).
</quote>

I think this means that presence of one of these three types of
descriptors is sufficient in order to be compliant with SPC-4.

Thanks,

Bart.


  parent reply	other threads:[~2014-07-17 11:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-29  3:52 Copy offload Martin K. Petersen
2014-05-29  3:52 ` [PATCH 1/6] block: Replace bi_integrity with bi_special Martin K. Petersen
2014-06-02 20:35   ` Nicholas A. Bellinger
2014-05-29  3:52 ` [PATCH 2/6] block: Implement support for copy offload operations Martin K. Petersen
2014-06-02 20:38   ` Nicholas A. Bellinger
2014-05-29  3:52 ` [PATCH 3/6] block: Introduce copy offload library function Martin K. Petersen
2014-06-02 20:40   ` Nicholas A. Bellinger
2014-05-29  3:52 ` [PATCH 4/6] block: Copy offload ioctl Martin K. Petersen
2014-06-02 20:42   ` Nicholas A. Bellinger
2014-05-29  3:52 ` [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present Martin K. Petersen
2014-06-02 20:43   ` Nicholas A. Bellinger
2014-06-02 20:59   ` Paolo Bonzini
2014-06-03  1:00     ` Martin K. Petersen
2014-06-03  9:13       ` Paolo Bonzini
2014-07-17 11:48   ` Bart Van Assche [this message]
2014-07-17 15:43     ` Martin K. Petersen
2014-05-29  3:52 ` [PATCH 6/6] [SCSI] sd: Implement copy offload support Martin K. Petersen
2014-05-29 14:48   ` Douglas Gilbert
2014-05-30  0:05     ` Martin K. Petersen
2014-06-02 20:46   ` Nicholas A. Bellinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53C7B7F1.2060005@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@fb.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nab@daterainc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).