From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: uas: kernel BUG at block/blk-tag.c:89 is back again :| Date: Mon, 21 Jul 2014 11:10:34 +0200 Message-ID: <53CCD90A.2020703@redhat.com> References: <53B2B4B2.8050100@redhat.com> <20140703060135.GA5292@infradead.org> <53B93FE3.8050607@redhat.com> <20140707101015.GB3544@infradead.org> <53BA95C0.3020607@redhat.com> <20140708095317.GA4306@infradead.org> <53BBBFC6.2030205@kernel.dk> <20140708095619.GA11196@infradead.org> <53BBC98C.4070004@kernel.dk> <53BBD51A.4070704@redhat.com> <53CCCC24.5050403@redhat.com> <53CCCC95.40204@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:52112 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753031AbaGUJLN (ORCPT ); Mon, 21 Jul 2014 05:11:13 -0400 In-Reply-To: <53CCCC95.40204@kernel.dk> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Jens Axboe , Christoph Hellwig Cc: "James E.J. Bottomley" , Sarah Sharp , linux-scsi@vger.kernel.org Hi, On 07/21/2014 10:17 AM, Jens Axboe wrote: > On 2014-07-21 10:15, Hans de Goede wrote: >> Hi, >> >> On 07/08/2014 01:25 PM, Hans de Goede wrote: >>> Hi, >>> >>> On 07/08/2014 12:35 PM, Jens Axboe wrote: >>>> On 2014-07-08 11:56, Christoph Hellwig wrote: >>>>> On Tue, Jul 08, 2014 at 11:54:14AM +0200, Jens Axboe wrote: >>>>>>> I've posted the patch in reply to another report and added Jens to the >>>>>>> Cc list. As the block maintainer he need to review and merge it. >>>>>> >>>>>> Which patch is this? >>>>> >>>>> This one: >>>>> >>>>> --- >>>>> From: Christoph Hellwig >>>>> Subject: block: don't assume last put of shared tags is for the host >>>>> >>>>> There is no inherent reason why the last put of a tag structure must be >>>>> the one for the Scsi_Host, as device model objects can be held for >>>>> arbitrary periods. Merge blk_free_tags and __blk_free_tags into a single >>>>> funtion that just release a references and get rid of the BUG() when the >>>>> host reference wasn't the last. >>>> >>>> Thanks, applied. I don't think I was ever CC'ed on this one, though. >>> >>> Thanks, good to hear. >> >> It seems this one has not made it into 3.16-rc6 somehow ? > > It'll go out shortly, was on vacation last week. It is queued up in for-linus. Ok, thanks for taking care of this. I hope you've enjoyed your vacation. Regards, Hans