linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: David Vrabel <david.vrabel@citrix.com>,
	xen-devel@lists.xen.org, linux-scsi@vger.kernel.org,
	JBottomley@parallels.com, target-devel@vger.kernel.org,
	konrad.wilk@oracle.com
Subject: Re: [Xen-devel] [PATCH V2 1/4] Add XEN pvSCSI protocol description
Date: Tue, 29 Jul 2014 09:39:54 +0200	[thread overview]
Message-ID: <53D74FCA.1080007@suse.com> (raw)
In-Reply-To: <53D65E09.5020901@citrix.com>

On 07/28/2014 04:28 PM, David Vrabel wrote:
> On 25/07/14 12:37, jgross@suse.com wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> Add the definition of pvSCSI protocol used between the pvSCSI frontend in a
>> XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0).
>>
>> This header was originally provided by Fujitsu for XEN based on Linux 2.6.18.
>> Changes are:
>> - added comment
>> - adapt to Linux style guide
>> - add support for larger SG-lists by putting them in an own granted page
>> - remove stale definitions
>
> This is a protocol extension and needs to be reviewed separately, and
> the Xen header needs updating as well.

Sure. The review can start right now. Updating the Xen header will be
done as soon as the drivers are accepted in Linux.

> The documentation for this protocol is rather lacking.  In particular it
> is missing the connection states.

Regarding documentation: I'll add some.

Regarding the connection states: I'd rather move the description in
blkif.h to xenbus.h than duplicating it in vscsiif.h. What do you think?


Juergen

  reply	other threads:[~2014-07-29  7:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25 11:37 [PATCH V2 0/4] Add XEN pvSCSI support jgross
2014-07-25 11:37 ` [PATCH V2 1/4] Add XEN pvSCSI protocol description jgross
2014-07-28 14:28   ` [Xen-devel] " David Vrabel
2014-07-29  7:39     ` Juergen Gross [this message]
2014-07-25 11:37 ` [PATCH V2 2/4] Introduce xen-scsifront module jgross
2014-07-29 13:53   ` Christoph Hellwig
2014-07-29 14:57     ` [Xen-devel] " Juergen Gross
2014-07-30  4:53       ` Juergen Gross
2014-08-01 12:08         ` Christoph Hellwig
2014-08-01 13:06           ` Juergen Gross
2014-08-01 13:41             ` Christoph Hellwig
2014-07-25 11:37 ` [PATCH V2 3/4] Introduce XEN scsiback module jgross
2014-07-26 15:23   ` Christoph Hellwig
2014-07-28  3:35     ` [Xen-devel] " Jürgen Groß
2014-07-29 12:28       ` Christoph Hellwig
2014-07-25 11:37 ` [PATCH V2 4/4] add xen pvscsi maintainer jgross
2014-07-25 17:38 ` [PATCH V2 0/4] Add XEN pvSCSI support Konrad Rzeszutek Wilk
2014-07-26  7:28   ` Juergen Gross

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53D74FCA.1080007@suse.com \
    --to=jgross@suse.com \
    --cc=JBottomley@parallels.com \
    --cc=david.vrabel@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).