From: Mike Christie <michaelc@cs.wisc.edu>
To: Anish Bhatt <anish@chelsio.com>
Cc: linux-scsi@vger.kernel.org, hch@infradead.org,
jbottomley@parallels.com, kxie@chelsio.com,
manojmalviya@chelsio.com
Subject: Re: [PATCH scsi 1/1] libiscsi : Add T10 Data Integrity Feature support
Date: Wed, 06 Aug 2014 21:25:42 -0500 [thread overview]
Message-ID: <53E2E3A6.7010402@cs.wisc.edu> (raw)
In-Reply-To: <1407364668-20931-2-git-send-email-anish@chelsio.com>
On 08/06/2014 05:37 PM, Anish Bhatt wrote
> @@ -436,12 +473,12 @@ static int iscsi_prep_scsi_cmd_pdu(struct iscsi_task *task)
> /* No unsolicit Data-Out's */
> hdr->flags |= ISCSI_FLAG_CMD_FINAL;
> } else {
> + unsigned in_len = iscsi_scsi_in_total_length(sc);
> hdr->flags |= ISCSI_FLAG_CMD_FINAL;
> zero_data(hdr->dlength);
> - hdr->data_length = cpu_to_be32(scsi_in(sc)->length);
> -
> if (sc->sc_data_direction == DMA_FROM_DEVICE)
> hdr->flags |= ISCSI_FLAG_CMD_READ;
> + hdr->data_length = cpu_to_be32(in_len);
> }
>
What tree and branch did you make these over? Have you seen the patches
from Sagi for iser and libiscsi support?
Could you rebuild this over Christoph's tree which has his patches:
git://git.infradead.org/users/hch/scsi-queue.git
next prev parent reply other threads:[~2014-08-07 2:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 22:37 [PATCH scsi 0/1] libiscsi : T10 DIF support Anish Bhatt
2014-08-06 22:37 ` [PATCH scsi 1/1] libiscsi : Add T10 Data Integrity Feature support Anish Bhatt
2014-08-07 2:25 ` Mike Christie [this message]
2014-08-07 2:35 ` Anish Bhatt
2014-08-08 22:01 ` Anish Bhatt
2014-08-14 9:25 ` Sagi Grimberg
2014-08-14 9:28 ` Anish Bhatt
2014-08-21 21:47 ` Martin K. Petersen
2014-08-21 21:49 ` Anish Bhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E2E3A6.7010402@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=anish@chelsio.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manojmalviya@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).