From: Tomas Henzl <thenzl@redhat.com>
To: Ching Huang <ching2048@areca.com.tw>,
Christoph Hellwig <hch@infradead.org>
Cc: jbottomley@parallels.com, dan.carpenter@oracle.com,
agordeev@redhat.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request
Date: Thu, 07 Aug 2014 14:45:00 +0200 [thread overview]
Message-ID: <53E374CC.2070707@redhat.com> (raw)
In-Reply-To: <1407124855.5217.23.camel@Centos6.3-64>
On 08/04/2014 06:00 AM, Ching Huang wrote:
> On Fri, 2014-08-01 at 05:35 -0700, Christoph Hellwig wrote:
>>> @@ -2220,8 +2220,7 @@ static int arcmsr_queue_command_lck(stru
>>> arcmsr_handle_virtual_command(acb, cmd);
>>> return 0;
>>> }
>>> - if (atomic_read(&acb->ccboutstandingcount) >=
>>> - ARCMSR_MAX_OUTSTANDING_CMD)
>>> + if (atomic_read(&acb->ccboutstandingcount) >= acb->maxOutstanding)
>>> return SCSI_MLQUEUE_HOST_BUSY;
>> The scsi midlayer already takes care of this check for you.
>>
> Hello Christoph,
>
> We have 4 types of Adapter that some adpaters have command queue less
> than ARCMSR_MAX_OUTSTANDING_CMD.
> So we have to check outstanding command number here.
I think you could set the correct value of can_queue in arcmsr_probe
after you have read the firmware spec.
>
> Thanks for your comment.
> Ching
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-08-07 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-01 8:39 [PATCH v1.3 4/18] arcmsr: limit max. number of SCSI command request Ching Huang
2014-08-01 12:35 ` Christoph Hellwig
2014-08-04 4:00 ` Ching Huang
2014-08-07 12:45 ` Tomas Henzl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E374CC.2070707@redhat.com \
--to=thenzl@redhat.com \
--cc=agordeev@redhat.com \
--cc=ching2048@areca.com.tw \
--cc=dan.carpenter@oracle.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).