* [PATCH] fusion: fix excess parameter kernel-doc warning
@ 2014-08-16 21:15 Randy Dunlap
2014-08-18 17:07 ` Ewan Milne
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2014-08-16 21:15 UTC (permalink / raw)
To: James Bottomley, Christoph Hellwig
Cc: linux-scsi, DL-MPTFusionLinux, MPT-FusionLinux.pdl
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc excess parameter warning:
Warning(..//drivers/message/fusion/mptbase.c:1411): Excess function parameter 'prod_name' description in 'mpt_get_product_name'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: DL-MPTFusionLinux@lsi.com
Cc: MPT-FusionLinux.pdl@avagotech.com
---
drivers/message/fusion/mptbase.c | 1 -
1 file changed, 1 deletion(-)
Index: lnx-317-rc1/drivers/message/fusion/mptbase.c
===================================================================
--- lnx-317-rc1.orig/drivers/message/fusion/mptbase.c
+++ lnx-317-rc1/drivers/message/fusion/mptbase.c
@@ -1400,7 +1400,6 @@ mpt_verify_adapter(int iocid, MPT_ADAPTE
* @vendor: pci vendor id
* @device: pci device id
* @revision: pci revision id
- * @prod_name: string returned
*
* Returns product string displayed when driver loads,
* in /proc/mpt/summary and /sysfs/class/scsi_host/host<X>/version_product
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fusion: fix excess parameter kernel-doc warning
2014-08-16 21:15 [PATCH] fusion: fix excess parameter kernel-doc warning Randy Dunlap
@ 2014-08-18 17:07 ` Ewan Milne
2014-08-27 23:47 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Ewan Milne @ 2014-08-18 17:07 UTC (permalink / raw)
To: Randy Dunlap
Cc: James Bottomley, Christoph Hellwig, linux-scsi, DL-MPTFusionLinux,
MPT-FusionLinux.pdl
On Sat, 2014-08-16 at 14:15 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc excess parameter warning:
>
> Warning(..//drivers/message/fusion/mptbase.c:1411): Excess function parameter 'prod_name' description in 'mpt_get_product_name'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: DL-MPTFusionLinux@lsi.com
> Cc: MPT-FusionLinux.pdl@avagotech.com
> ---
> drivers/message/fusion/mptbase.c | 1 -
> 1 file changed, 1 deletion(-)
>
> Index: lnx-317-rc1/drivers/message/fusion/mptbase.c
> ===================================================================
> --- lnx-317-rc1.orig/drivers/message/fusion/mptbase.c
> +++ lnx-317-rc1/drivers/message/fusion/mptbase.c
> @@ -1400,7 +1400,6 @@ mpt_verify_adapter(int iocid, MPT_ADAPTE
> * @vendor: pci vendor id
> * @device: pci device id
> * @revision: pci revision id
> - * @prod_name: string returned
> *
> * Returns product string displayed when driver loads,
> * in /proc/mpt/summary and /sysfs/class/scsi_host/host<X>/version_product
> --
Goes with commit c9834c70efbaaa1461ec04289d97a842244fb294.
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fusion: fix excess parameter kernel-doc warning
2014-08-18 17:07 ` Ewan Milne
@ 2014-08-27 23:47 ` Randy Dunlap
2014-08-28 0:55 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2014-08-27 23:47 UTC (permalink / raw)
To: emilne
Cc: James Bottomley, Christoph Hellwig, linux-scsi, DL-MPTFusionLinux,
MPT-FusionLinux.pdl
On 08/18/14 10:07, Ewan Milne wrote:
> On Sat, 2014-08-16 at 14:15 -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Fix kernel-doc excess parameter warning:
>>
>> Warning(..//drivers/message/fusion/mptbase.c:1411): Excess function parameter 'prod_name' description in 'mpt_get_product_name'
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: DL-MPTFusionLinux@lsi.com
>> Cc: MPT-FusionLinux.pdl@avagotech.com
>> ---
>> drivers/message/fusion/mptbase.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> Index: lnx-317-rc1/drivers/message/fusion/mptbase.c
>> ===================================================================
>> --- lnx-317-rc1.orig/drivers/message/fusion/mptbase.c
>> +++ lnx-317-rc1/drivers/message/fusion/mptbase.c
>> @@ -1400,7 +1400,6 @@ mpt_verify_adapter(int iocid, MPT_ADAPTE
>> * @vendor: pci vendor id
>> * @device: pci device id
>> * @revision: pci revision id
>> - * @prod_name: string returned
>> *
>> * Returns product string displayed when driver loads,
>> * in /proc/mpt/summary and /sysfs/class/scsi_host/host<X>/version_product
>> --
>
> Goes with commit c9834c70efbaaa1461ec04289d97a842244fb294.
>
> Reviewed-by: Ewan D. Milne <emilne@redhat.com>
Christoph, did you pick up this patch or should I merge it
with my documentation patches?
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fusion: fix excess parameter kernel-doc warning
2014-08-27 23:47 ` Randy Dunlap
@ 2014-08-28 0:55 ` Christoph Hellwig
2014-08-28 6:28 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2014-08-28 0:55 UTC (permalink / raw)
To: Randy Dunlap
Cc: emilne, James Bottomley, Christoph Hellwig, linux-scsi,
DL-MPTFusionLinux, MPT-FusionLinux.pdl
On Wed, Aug 27, 2014 at 04:47:24PM -0700, Randy Dunlap wrote:
> > Goes with commit c9834c70efbaaa1461ec04289d97a842244fb294.
> >
> > Reviewed-by: Ewan D. Milne <emilne@redhat.com>
>
> Christoph, did you pick up this patch or should I merge it
> with my documentation patches?
I did as mentioned in my reply to your other patch.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] fusion: fix excess parameter kernel-doc warning
2014-08-28 0:55 ` Christoph Hellwig
@ 2014-08-28 6:28 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2014-08-28 6:28 UTC (permalink / raw)
To: Christoph Hellwig
Cc: emilne, James Bottomley, linux-scsi, DL-MPTFusionLinux,
MPT-FusionLinux.pdl
On 08/27/14 17:55, Christoph Hellwig wrote:
> On Wed, Aug 27, 2014 at 04:47:24PM -0700, Randy Dunlap wrote:
>>> Goes with commit c9834c70efbaaa1461ec04289d97a842244fb294.
>>>
>>> Reviewed-by: Ewan D. Milne <emilne@redhat.com>
>>
>> Christoph, did you pick up this patch or should I merge it
>> with my documentation patches?
>
> I did as mentioned in my reply to your other patch.
Thanks. Sorry I missed that...
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-08-28 6:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-16 21:15 [PATCH] fusion: fix excess parameter kernel-doc warning Randy Dunlap
2014-08-18 17:07 ` Ewan Milne
2014-08-27 23:47 ` Randy Dunlap
2014-08-28 0:55 ` Christoph Hellwig
2014-08-28 6:28 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).