Re: Debugging scsi abort handling ?

Paolo Bonzini
2014-08-28T14:56:21Z

Il 28/08/2014 16:17, Hannes Reinecke ha scritto:
>>
> As mentioned earlier, as soon as SCSI EH is invoked control
> is assumed to be transferred back to the SCSI midlayer.
> How the midlayer interprets any return value from the various eh_XX
> callbacks is immaterial to the LLDD.
>
> So even if the eh_abort returns FAILED control is still with the SCSI
> midlayer, so the earlier statements apply.
> IE the command will be short-circuited by the block layer anyway if
> ->scsi_done() is called.

As I parsed it, the question is not whether the short-circuiting will
happen. It's whether you will have use-after-free bugs or not if you
call ->scsi_done() after eh_abort returns FAILED.

Paolo