Re: Debugging scsi abort handling ?

James Bottomley
2014-08-28T14:08:42Z

On Thu, 2014-08-28 at 14:37 +0200, Hans de Goede wrote:
> Hi,
>
> On 08/28/2014 02:33 PM, Paolo Bonzini wrote:
> > Il 28/08/2014 14:26, Hans de Goede ha scritto:
> >>>> Then, blk_complete_request will do nothing because its call to
> >>>> blk_mark_rq_complete returns true.
> >>>>
> >>>> All this, of course, as long as ->scsi_done is called _before_ eh_abort
> >>>> returns.
> >> What about calling scsi_done after eh_abort if eh_abort returned FAILED?
> >
> > I invoke the fifth amendment. :)
>
> Although I appreciate the tongue in cheek answer, this was sort of a serious
> question, as at the moment this may happen with the uas driver.

The answer is no. It's part of the internal mid layer functions you
don't need to know about. You just call the command done functions and
try not to care what actual function they point to.

James