Re: [PATCH 5/6] scsi: mvsas: Delete mvs_tag_init()

Damien Le Moal
2022-09-29T02:18:44Z

On 9/28/22 21:27, John Garry wrote:
> All mvs_tag_init() does is zero the tag bitmap, but this is already done
> with the kzalloc() call to alloc the tags, so delete this unneeded
> function.
>
> Signed-off-by: John Garry <john.garry@huawei.com>

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
> drivers/scsi/mvsas/mv_init.c | 2 --
> drivers/scsi/mvsas/mv_sas.c | 7 -------
> drivers/scsi/mvsas/mv_sas.h | 1 -
> 3 files changed, 10 deletions(-)
>
> diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
> index 2fde496fff5f..c85fb812ad43 100644
> --- a/drivers/scsi/mvsas/mv_init.c
> +++ b/drivers/scsi/mvsas/mv_init.c
> @@ -286,8 +286,6 @@ static int mvs_alloc(struct mvs_info *mvi, struct Scsi_Host *shost)
> }
> mvi->tags_num = slot_nr;
>
> - /* Initialize tags */
> - mvs_tag_init(mvi);
> return 0;
> err_out:
> return 1;
> diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
> index a6867dae0e7c..0810e6c930e1 100644
> --- a/drivers/scsi/mvsas/mv_sas.c
> +++ b/drivers/scsi/mvsas/mv_sas.c
> @@ -51,13 +51,6 @@ inline int mvs_tag_alloc(struct mvs_info *mvi, u32 *tag_out)
> return 0;
> }
>
> -void mvs_tag_init(struct mvs_info *mvi)
> -{
> - int i;
> - for (i = 0; i < mvi->tags_num; ++i)
> - mvs_tag_clear(mvi, i);
> -}
> -
> static struct mvs_info *mvs_find_dev_mvi(struct domain_device *dev)
> {
> unsigned long i = 0, j = 0, hi = 0;
> diff --git a/drivers/scsi/mvsas/mv_sas.h b/drivers/scsi/mvsas/mv_sas.h
> index 509d8f32a04f..fe57665bdb50 100644
> --- a/drivers/scsi/mvsas/mv_sas.h
> +++ b/drivers/scsi/mvsas/mv_sas.h
> @@ -428,7 +428,6 @@ void mvs_tag_clear(struct mvs_info *mvi, u32 tag);
> void mvs_tag_free(struct mvs_info *mvi, u32 tag);
> void mvs_tag_set(struct mvs_info *mvi, unsigned int tag);
> int mvs_tag_alloc(struct mvs_info *mvi, u32 *tag_out);
> -void mvs_tag_init(struct mvs_info *mvi);
> void mvs_iounmap(void __iomem *regs);
> int mvs_ioremap(struct mvs_info *mvi, int bar, int bar_ex);
> void mvs_phys_reset(struct mvs_info *mvi, u32 phy_mask, int hard);

--
Damien Le Moal
Western Digital Research