From: Mike Christie <michaelc@cs.wisc.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-scsi@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: potential buffer overrun in __iscsi_conn_send_pdu()
Date: Mon, 01 Sep 2014 22:22:11 -0500 [thread overview]
Message-ID: <540537E3.7090903@cs.wisc.edu> (raw)
In-Reply-To: <20140901180650.GB6549@mwanda>
On 9/1/14, 1:06 PM, Dan Carpenter wrote:
> I never heard back on this. It still looks like a very serious bug
> with security implications etc.
>
Sorry about that. I must have missed the original. You are right. I
should have a tested patch by tomorrow.
> regards,
> dan carpenter
>
> On Mon, Jun 24, 2013 at 06:46:31PM +0300, Dan Carpenter wrote:
>> My static checker complains about a possible array overflow in
>> __iscsi_conn_send_pdu().
>>
>> drivers/scsi/libiscsi.c
>> 743 if (data_size) {
>> 744 memcpy(task->data, data, data_size);
>> 745 task->data_count = data_size;
>> 746 } else
>> 747 task->data_count = 0;
>> 748
>>
>> "data_size" comes from skb->data and we haven't checked that it is less
>> than ISCSI_DEF_MAX_RECV_SEG_LEN (8192).
>>
>> The call tree is:
>> iscsi_if_recv_msg()
>> iscsi_conn_send_pdu()
>> __iscsi_conn_send_pdu()
>>
>> I'm a newbie to this code, so I'm not sure if this is a real bug or not.
>>
>> regards,
>> dan carpenter
prev parent reply other threads:[~2014-09-02 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-24 15:46 potential buffer overrun in __iscsi_conn_send_pdu() Dan Carpenter
2014-09-01 18:06 ` Dan Carpenter
2014-09-02 3:22 ` Mike Christie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540537E3.7090903@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=dan.carpenter@oracle.com \
--cc=keescook@chromium.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox