Re: [PATCH 2/5] kexec: Export kexec_in_progress

[Brian King <brking@linux.vnet.ibm.com>]

On 08/30/2014 03:02 PM, Eric W. Biederman wrote:
> Brian King <brking@linux.vnet.ibm.com> writes:
> 
>> On 08/04/2014 09:21 AM, Brian King wrote:
>>> On 07/28/2014 03:28 PM, Brian King wrote:
>>>>
>>>> Export kexec_in_progress for use by device drivers and other modules
>>>> to optimize kexec boot.
>>>>
>>>> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>>>> ---
>>>>
>>>>  kernel/kexec.c |    2 ++
>>>>  1 file changed, 2 insertions(+)
>>>>
>>>> diff -puN kernel/kexec.c~kexec_export_in_prog kernel/kexec.c
>>>> --- linux/kernel/kexec.c~kexec_export_in_prog	2014-07-23 17:05:24.851887935 -0500
>>>> +++ linux-bjking1/kernel/kexec.c	2014-07-23 17:05:24.856887970 -0500
>>>> @@ -1716,3 +1716,5 @@ int kernel_kexec(void)
>>>>  	mutex_unlock(&kexec_mutex);
>>>>  	return error;
>>>>  }
>>>> +
>>>> +EXPORT_SYMBOL_GPL(kexec_in_progress);
>>>
>>> Eric,
>>>
>>> Can I get an ack on this so we can take this entire series through the SCSI tree?
>>
>> Eric,
>>
>> Any issues with this patch?
> 
> No huge issues except that patch description is largely uniformitive and
> actually wrong.  kexec_in_progress is never set at boot/kernel startup.

Good point. How about this instead:

Export kexec_in_progress for use by device drivers and other modules
to optimize shutdown handling during kexec.

Thanks,

Brian

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center