From: Randy Dunlap <rdunlap@infradead.org>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
linux-scsi <linux-scsi@vger.kernel.org>
Cc: James Bottomley <jbottomley@parallels.com>,
Anish Bhatt <anish@chelsio.com>
Subject: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS
Date: Fri, 19 Sep 2014 16:50:59 -0700 [thread overview]
Message-ID: <541CC163.3080709@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
Fix kconfig dependency warnings which can lead to build errors:
warning: (SCSI_BNX2X_FCOE && LIBFCOE && TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)
warning: (FCOE && FCOE_FNIC) selects LIBFCOE which has unmet direct dependencies (SCSI_LOWLEVEL && SCSI && SCSI_FC_ATTRS)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
drivers/scsi/Kconfig | 3 +++
drivers/scsi/qla2xxx/Kconfig | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
--- linux-next-20140918.orig/drivers/scsi/Kconfig
+++ linux-next-20140918/drivers/scsi/Kconfig
@@ -601,6 +601,7 @@ config LIBFC
config LIBFCOE
tristate "LibFCoE module"
+ depends on SCSI_FC_ATTRS
select LIBFC
---help---
Library for Fibre Channel over Ethernet module
@@ -608,6 +609,7 @@ config LIBFCOE
config FCOE
tristate "FCoE module"
depends on PCI
+ depends on SCSI_FC_ATTRS
select LIBFCOE
---help---
Fibre Channel over Ethernet module
@@ -615,6 +617,7 @@ config FCOE
config FCOE_FNIC
tristate "Cisco FNIC Driver"
depends on PCI && X86
+ depends on SCSI_FC_ATTRS
select LIBFCOE
help
This is support for the Cisco PCI-Express FCoE HBA.
--- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig
+++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig
@@ -30,7 +30,7 @@ config SCSI_QLA_FC
config TCM_QLA2XXX
tristate "TCM_QLA2XXX fabric module for Qlogic 2xxx series target mode HBAs"
- depends on SCSI_QLA_FC && TARGET_CORE
+ depends on SCSI_QLA_FC && TARGET_CORE && SCSI_FC_ATTRS
select LIBFC
select BTREE
default n
next reply other threads:[~2014-09-19 23:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 23:50 Randy Dunlap [this message]
2014-09-22 14:42 ` [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS Christoph Hellwig
2014-09-22 15:49 ` David Miller
2014-09-22 15:56 ` David Miller
2014-09-22 16:44 ` Christoph Hellwig
2014-09-22 16:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541CC163.3080709@infradead.org \
--to=rdunlap@infradead.org \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox