From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bvanassche@acm.org>,
Sebastian Herbszt <herbszt@gmx.de>,
linux-scsi@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] scsi_host: fix comment
Date: Tue, 30 Sep 2014 13:15:31 +0200 [thread overview]
Message-ID: <542A90D3.1050602@suse.de> (raw)
In-Reply-To: <542A9054.1000306@acm.org>
On 09/30/2014 01:13 PM, Bart Van Assche wrote:
> On 09/20/14 13:37, Sebastian Herbszt wrote:
>> Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the
>> order
>> of Scsi_Host members. Update the comment to reflect this.
>>
>> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>>
>> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
>> index ba20347..d4e0509 100644
>> --- a/include/scsi/scsi_host.h
>> +++ b/include/scsi/scsi_host.h
>> @@ -603,13 +603,13 @@ struct Scsi_Host {
>> unsigned long last_reset;
>>
>>
>> /*
>> * These three parameters can be used to allow for wide scsi,
>> * and for host adapters that support multiple busses
>> - * The first two should be set to 1 more than the actual max id
>> + * The last two should be set to 1 more than the actual max id
>> * or lun (e.g. 8 for SCSI parallel systems).
>> */
>> unsigned int max_channel;
>> unsigned int max_id;
>> u64 max_lun;
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-30 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 11:37 [PATCH] scsi_host: fix comment Sebastian Herbszt
2014-09-30 11:13 ` Bart Van Assche
2014-09-30 11:15 ` Hannes Reinecke [this message]
2014-09-30 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A90D3.1050602@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=herbszt@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox