* [PATCH] scsi_host: fix comment
@ 2014-09-20 11:37 Sebastian Herbszt
2014-09-30 11:13 ` Bart Van Assche
2014-09-30 13:44 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Sebastian Herbszt @ 2014-09-20 11:37 UTC (permalink / raw)
To: linux-scsi; +Cc: Hannes Reinecke, Sebastian Herbszt
Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the order
of Scsi_Host members. Update the comment to reflect this.
Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
index ba20347..d4e0509 100644
--- a/include/scsi/scsi_host.h
+++ b/include/scsi/scsi_host.h
@@ -603,13 +603,13 @@ struct Scsi_Host {
unsigned long last_reset;
/*
* These three parameters can be used to allow for wide scsi,
* and for host adapters that support multiple busses
- * The first two should be set to 1 more than the actual max id
+ * The last two should be set to 1 more than the actual max id
* or lun (e.g. 8 for SCSI parallel systems).
*/
unsigned int max_channel;
unsigned int max_id;
u64 max_lun;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scsi_host: fix comment
2014-09-20 11:37 [PATCH] scsi_host: fix comment Sebastian Herbszt
@ 2014-09-30 11:13 ` Bart Van Assche
2014-09-30 11:15 ` Hannes Reinecke
2014-09-30 13:44 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Bart Van Assche @ 2014-09-30 11:13 UTC (permalink / raw)
To: Sebastian Herbszt, linux-scsi; +Cc: Hannes Reinecke, Christoph Hellwig
On 09/20/14 13:37, Sebastian Herbszt wrote:
> Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the order
> of Scsi_Host members. Update the comment to reflect this.
>
> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>
> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
> index ba20347..d4e0509 100644
> --- a/include/scsi/scsi_host.h
> +++ b/include/scsi/scsi_host.h
> @@ -603,13 +603,13 @@ struct Scsi_Host {
> unsigned long last_reset;
>
>
> /*
> * These three parameters can be used to allow for wide scsi,
> * and for host adapters that support multiple busses
> - * The first two should be set to 1 more than the actual max id
> + * The last two should be set to 1 more than the actual max id
> * or lun (e.g. 8 for SCSI parallel systems).
> */
> unsigned int max_channel;
> unsigned int max_id;
> u64 max_lun;
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi_host: fix comment
2014-09-30 11:13 ` Bart Van Assche
@ 2014-09-30 11:15 ` Hannes Reinecke
0 siblings, 0 replies; 4+ messages in thread
From: Hannes Reinecke @ 2014-09-30 11:15 UTC (permalink / raw)
To: Bart Van Assche, Sebastian Herbszt, linux-scsi; +Cc: Christoph Hellwig
On 09/30/2014 01:13 PM, Bart Van Assche wrote:
> On 09/20/14 13:37, Sebastian Herbszt wrote:
>> Commit 1abf635 (scsi: use 64-bit value for 'max_luns') changed the
>> order
>> of Scsi_Host members. Update the comment to reflect this.
>>
>> Signed-off-by: Sebastian Herbszt <herbszt@gmx.de>
>>
>> diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h
>> index ba20347..d4e0509 100644
>> --- a/include/scsi/scsi_host.h
>> +++ b/include/scsi/scsi_host.h
>> @@ -603,13 +603,13 @@ struct Scsi_Host {
>> unsigned long last_reset;
>>
>>
>> /*
>> * These three parameters can be used to allow for wide scsi,
>> * and for host adapters that support multiple busses
>> - * The first two should be set to 1 more than the actual max id
>> + * The last two should be set to 1 more than the actual max id
>> * or lun (e.g. 8 for SCSI parallel systems).
>> */
>> unsigned int max_channel;
>> unsigned int max_id;
>> u64 max_lun;
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi_host: fix comment
2014-09-20 11:37 [PATCH] scsi_host: fix comment Sebastian Herbszt
2014-09-30 11:13 ` Bart Van Assche
@ 2014-09-30 13:44 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2014-09-30 13:44 UTC (permalink / raw)
To: Sebastian Herbszt; +Cc: linux-scsi, Hannes Reinecke
Thanks, applied to the core-for-3.18 tree.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-09-30 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-20 11:37 [PATCH] scsi_host: fix comment Sebastian Herbszt
2014-09-30 11:13 ` Bart Van Assche
2014-09-30 11:15 ` Hannes Reinecke
2014-09-30 13:44 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox