From: Hannes Reinecke <hare@suse.de>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <jbottomley@parallels.com>,
Sagi Grimberg <sagig@dev.mellanox.co.il>,
Webb Scales <webbnh@hp.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/5] NCR5380: Whitespace cleanup
Date: Thu, 02 Oct 2014 13:12:13 +0200 [thread overview]
Message-ID: <542D330D.2060500@suse.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1410022104070.22727@nippy.intranet>
On 10/02/2014 01:07 PM, Finn Thain wrote:
>
> On Thu, 2 Oct 2014, Hannes Reinecke wrote:
>
>> Signed-off-by: Hannes Reinecke <hare@suse.de>
>> ---
>> drivers/scsi/NCR5380.c | 652 +++++++++++++++++++++++++------------------------
>> 1 file changed, 333 insertions(+), 319 deletions(-)
>>
>
> This is going to break about 30 or 40 patches that I'm working on. Can we
> not do this yet? The white space clean up is a smaller patch if it happens
> after all the other bug fixing and modernization work.
>
Oh, you're most welcome.
I've just included it as my eyes nearly fell out when turning on
syntax highlighting.
The patch is an RFC anyway, so I doubt it'll be included in 3.18.
And indeed the NCR5380 is in dire need of modernization; having
three to four identical copies with just minor modifications
between each simply cries out for consolidation.
Thanks for doing that.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-02 11:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 10:43 [RFC PATCH 0/5] Remove scmd->tag Hannes Reinecke
2014-10-02 10:43 ` [PATCH 1/5] NCR5380: Whitespace cleanup Hannes Reinecke
2014-10-02 11:07 ` Finn Thain
2014-10-02 11:12 ` Hannes Reinecke [this message]
2014-10-02 10:43 ` [PATCH 2/5] scsi: Remove references to linked commands Hannes Reinecke
2014-10-02 10:43 ` [PATCH 3/5] vmw_pvscsi: fixup tagging Hannes Reinecke
2014-10-02 10:43 ` [PATCH 4/5] tcm_loop: Fixup tag handling Hannes Reinecke
2014-10-02 10:43 ` [PATCH 5/5] scsi: Remove scmd->tag Hannes Reinecke
2014-10-02 11:22 ` Christoph Hellwig
2014-10-02 11:36 ` Hannes Reinecke
2014-10-02 11:48 ` Finn Thain
2014-10-02 11:20 ` [RFC PATCH 0/5] " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D330D.2060500@suse.de \
--to=hare@suse.de \
--cc=fthain@telegraphics.com.au \
--cc=hch@lst.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=sagig@dev.mellanox.co.il \
--cc=webbnh@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox