From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 01/29] ncr5380: Use printk() not pr_debug() Date: Mon, 06 Oct 2014 11:11:32 +0200 Message-ID: <54325CC4.8070800@suse.de> References: <20141002065628.256592712@telegraphics.com.au> <20141002065628.506518628@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141002065628.506518628@telegraphics.com.au> Sender: linux-m68k-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" Cc: Michael Schmitz , Sam Creasey , linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On 10/02/2014 08:56 AM, Finn Thain wrote: > Having defined NDEBUG, and having set the console log level, I'd like= to see > some output. Don't use pr_debug(), it's annoying to have to define DE= BUG as > well. >=20 > Signed-off-by: Finn Thain >=20 > --- >=20 > Use of pr_debug() here was a bad idea of mine. Joe was right when > he questioned it. >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)