From: Douglas Gilbert <dgilbert@interlog.com>
To: Christoph Hellwig <hch@infradead.org>,
"Elliott, Robert (Server Storage)" <Elliott@hp.com>
Cc: "James Bottomley (jbottomley@parallels.com)"
<jbottomley@parallels.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Don Brace (PMC)" <Don.Brace@pmcs.com>,
"Scales, Webb" <webb.scales@hp.com>
Subject: Re: Concurrent SG_SCSI_RESET ioctls
Date: Tue, 14 Oct 2014 12:42:26 -0400 [thread overview]
Message-ID: <543D5272.5080102@interlog.com> (raw)
In-Reply-To: <20141014111354.GA3022@infradead.org>
On 14-10-14 07:13 AM, Christoph Hellwig wrote:
> On Sat, Oct 11, 2014 at 10:06:47PM +0000, Elliott, Robert (Server Storage) wrote:
>> Thanks. That's a bit better, but sg_reset can now run into
>> "No such device" errors.
>
> That's the -ENODEV we return if another reset is in progress. Given
> that I suspect sg_reset is the prime if not only user of this interface
> I'm happy to change the error code we return here to anything Doug
> agrees to.
I don't mind if you change it. However I plan to release
sg3_utils-1.40 in the next 2 or 3 weeks, so that would
be the earliest a revised sg_reset would be available for
distros. Improving error reports is something I always
like to do (so ENODEV for the "in progress" case seems a
bit strident).
On the other hand, the existing sg_reset code with --no-esc
has been in place since sg3_utils-1.36 [20130531]. So there
is a good chance current distributions have that version or
later.
Doug Gilbert
next prev parent reply other threads:[~2014-10-14 16:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 23:32 Concurrent SG_SCSI_RESET ioctls Elliott, Robert (Server Storage)
2014-10-11 11:05 ` Christoph Hellwig
2014-10-11 16:11 ` Christoph Hellwig
2014-10-11 22:06 ` Elliott, Robert (Server Storage)
2014-10-14 11:13 ` Christoph Hellwig
2014-10-14 16:42 ` Douglas Gilbert [this message]
2014-10-15 13:25 ` Christoph Hellwig
2014-10-15 14:34 ` Elliott, Robert (Server Storage)
2014-10-24 14:51 ` Christoph Hellwig
2014-10-24 16:29 ` Douglas Gilbert
2014-10-11 23:04 ` Elliott, Robert (Server Storage)
2014-10-13 9:15 ` Bart Van Assche
2014-10-13 10:23 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543D5272.5080102@interlog.com \
--to=dgilbert@interlog.com \
--cc=Don.Brace@pmcs.com \
--cc=Elliott@hp.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=webb.scales@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox