From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>, Christoph Hellwig <hch@lst.de>
Cc: linux-scsi@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Douglas Gilbert <dgilbert@interlog.com>
Subject: Re: [PATCH] scsi: PC partition tables are little endian
Date: Fri, 17 Oct 2014 17:24:03 +0200 [thread overview]
Message-ID: <54413493.9050702@suse.de> (raw)
In-Reply-To: <20141017131349.GB16538@infradead.org>
On 10/17/2014 03:13 PM, Christoph Hellwig wrote:
> ping?
>
> On Wed, Oct 01, 2014 at 08:31:01PM +0200, Christoph Hellwig wrote:
>> As sparse correctly pointed out scsi_partsize should use get_unaligned_le32
>> to read PC partition tables from disk, as they are little endian.
>>
>> The result of this bug is that we returned incorrect geometries on big
>> endian systems when using the scsicam variant. Which probably doesn't
>> matter as only old x86 systems every cared about the geometry.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-10-17 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 18:31 [PATCH] scsi: PC partition tables are little endian Christoph Hellwig
2014-10-17 13:13 ` Christoph Hellwig
2014-10-17 15:24 ` Hannes Reinecke [this message]
2014-10-17 23:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54413493.9050702@suse.de \
--to=hare@suse.de \
--cc=dgilbert@interlog.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox