Re: [PATCH v2 12/12] IB/srp: Add multichannel support

[Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>]

On 10/17/14 13:06, Christoph Hellwig wrote:
>>   	} else {
>> +		if (blk_mq_unique_tag_to_hwq(rsp->tag) != ch - target->ch)
>> +			pr_err("Channel idx mismatch: tag %#llx <> ch %#lx\n",
>> +			       rsp->tag, ch - target->ch);
>>   		scmnd = scsi_host_find_tag(target->scsi_host, rsp->tag);
>
> Shouldn't we do this validity check inside scsi_host_find_tag, so that
> all callers get it? That means adding an argument to it,  but there are
> very few callers at the moment.

Hello Christoph,

That pr_err() statement was convenient while debugging the multiqueue 
code in the SRP initiator driver but can be left out. Would you agree 
with leaving the above three lines of debug code out instead of adding 
an additional argument to scsi_host_find_tag() ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html