From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bart Van Assche Subject: Re: [PATCH v2 03/12] scsi-mq: Add support for multiple hardware queues Date: Wed, 29 Oct 2014 13:22:29 +0100 Message-ID: <5450DC05.1010907@acm.org> References: <5433E43D.3010107@acm.org> <5433E4AB.8030306@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from albert.telenet-ops.be ([195.130.137.90]:58468 "EHLO albert.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932585AbaJ2MWg (ORCPT ); Wed, 29 Oct 2014 08:22:36 -0400 In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Martin K. Petersen" Cc: Christoph Hellwig , Jens Axboe , Sagi Grimberg , Sebastian Parschauer , Robert Elliott , Ming Lei , "linux-scsi@vger.kernel.org" , linux-rdma On 10/28/14 03:01, Martin K. Petersen wrote: >>>>>> "Bart" == Bart Van Assche writes: > > Bart> Allow a SCSI LLD to declare how many hardware queues it supports > Bart> by setting Scsi_Host.nr_hw_queues before calling scsi_add_host(). > > Bart> Note: it is assumed that each hardware queue has a queue depth of > Bart> shost-> can_queue. In other words, the total queue depth per host > Bart> is (number of hardware queues) * (shost->can_queue). > > I suggest you emphasize that assumption in the header file. > > Also: What about the host template? > > Reviewed-by: Martin K. Petersen Hello Martin, Thanks for reviewing the blk-core and SCSI-core patches in this series. Regarding nr_hw_queues and the SCSI host template: setting that parameter in the host template is supported. I will mention this in the patch description. I will also clarify the queue size assumptions in scsi_host.h. Bart.