Re: [PATCH 1/2] ipr: Disable async aborts

[Brian King <brking@linux.vnet.ibm.com>]

On 10/28/2014 03:47 AM, Christoph Hellwig wrote:
> On Mon, Oct 27, 2014 at 07:50:03AM -0700, James Bottomley wrote:
>> On Mon, 2014-10-27 at 09:37 -0500, Brian King wrote:
>>> The ipr driver does not yet support async aborts, so disable this
>>> for now.
>>>
>>> Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
>>
>> By "does not yet support" do you mean doesn't work with or merely not
>> tested with but seems to work OK?  if the former, then surely this
>> should be a fixes patch with a cc to stable for all the kernels async
>> abort is in (which is 3.14)
> 
> I'm pretty sure this patch is incorrect, and that what ever issue should
> have been described in this patch are the same EH problems we fixed in
> the last couple releases.  I've also talked to Hannes a while ago, and
> we agree that we want to remove this flag ASAP as it's inviting this

I think we can likely drop the first in the series here. I've reverted it
and have been running abort testing for a bit and haven't hit any issues.
Unless I see anything overnight, I'll resend the second patch by itself and
cc stable.

Thanks,

Brian

-- 
Brian King
Power Linux I/O
IBM Linux Technology Center