Re: [PATCH 06/11] mptfusion: don't change queue type in ->change_queue_depth

[Hannes Reinecke <hare@suse.de>]

On 11/04/2014 08:54 AM, Christoph Hellwig wrote:
> This function shouldn't change the queue type, just the depth.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/message/fusion/mptscsih.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c
> index 00bd13d..c0d84a0 100644
> --- a/drivers/message/fusion/mptscsih.c
> +++ b/drivers/message/fusion/mptscsih.c
> @@ -2322,7 +2322,6 @@ mptscsih_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
>  	VirtTarget 		*vtarget;
>  	struct scsi_target 	*starget;
>  	int			max_depth;
> -	int			tagged;
>  	MPT_ADAPTER		*ioc = hd->ioc;
>  
>  	starget = scsi_target(sdev);
> @@ -2347,12 +2346,8 @@ mptscsih_change_queue_depth(struct scsi_device *sdev, int qdepth, int reason)
>  
>  	if (qdepth > max_depth)
>  		qdepth = max_depth;
> -	if (qdepth == 1)
> -		tagged = 0;
> -	else
> -		tagged = MSG_SIMPLE_TAG;
>  
> -	scsi_adjust_queue_depth(sdev, tagged, qdepth);
> +	scsi_adjust_queue_depth(sdev, scsi_get_tag_type(sdev), qdepth);
>  	return sdev->queue_depth;
>  }
>  
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html