From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH 4/6] st: call scsi_set_medium_removal directly Date: Wed, 05 Nov 2014 15:13:56 +0100 Message-ID: <545A30A4.6090303@suse.de> References: <1414661229-15199-1-git-send-email-hch@lst.de> <1414661229-15199-5-git-send-email-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52012 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751198AbaKEON6 (ORCPT ); Wed, 5 Nov 2014 09:13:58 -0500 In-Reply-To: <1414661229-15199-5-git-send-email-hch@lst.de> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig , linux-scsi@vger.kernel.org Cc: Douglas Gilbert , Robert Elliott On 10/30/2014 10:27 AM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > drivers/scsi/st.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) >=20 > diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c > index 7d2e036..e46e02b2 100644 > --- a/drivers/scsi/st.c > +++ b/drivers/scsi/st.c > @@ -861,17 +861,16 @@ static int set_mode_densblk(struct scsi_tape * = STp, struct st_modedef * STm) > /* Lock or unlock the drive door. Don't use when st_request allocate= d. */ > static int do_door_lock(struct scsi_tape * STp, int do_lock) > { > - int retval, cmd; > + int retval; > =20 > - cmd =3D do_lock ? SCSI_IOCTL_DOORLOCK : SCSI_IOCTL_DOORUNLOCK; > DEBC_printk(STp, "%socking drive door.\n", do_lock ? "L" : "Unl"); > - retval =3D scsi_ioctl(STp->device, cmd, NULL); > - if (!retval) { > + > + retval =3D scsi_set_medium_removal(STp->device, > + do_lock ? SCSI_REMOVAL_PREVENT : SCSI_REMOVAL_ALLOW); > + if (!retval) > STp->door_locked =3D do_lock ? ST_LOCKED_EXPLICIT : ST_UNLOCKED; > - } > - else { > + else > STp->door_locked =3D ST_LOCK_FAILS; > - } > return retval; > } > =20 >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 21284 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html